test: #188, #364, #365, #377, #432, #442, #446 #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed obsolete Nix configuration files (default.nix, node-env.nix, and node-packages.nix) from the frontend module. This change is part of a broader effort to update and realign the frontend's build and deployment process with the backend's, ensuring a more streamlined and optimized development environment. The removal of these files paves the way for introducing a revised and more efficient Nix setup that better mirrors the backend's configuration and fulfills the specified acceptance criteria for development environments and dependencies.
This commit introduces a new yarn2nix based package definition for the frontend application. By adding this Nix expression, developers can easily incorporate the project into their nix-shell based environment. Changes: - Added a new file `govtool/frontend/default.nix` that defines the yarn2nix based package configuration for the frontend application "govtool-frontend". This file includes settings for the project name, source directory, package.json file, and yarn.lock file wrapped in the `mkYarnPackage` function, enabling developers to utilize the project seamlessly in their nix-shell based environments.
This commit changes the target name from 'docker' to 'docker-compose' in the 'utils.mk' file under 'scripts/govtool' directory. This more descriptive name accurately reflects the purpose of the target, making it easier for developers to understand the functionality associated with it. Changes: - Renamed the target from 'docker' to 'docker-compose' in 'scripts/govtool/utils.mk' to improve clarity and reflect the actual usage of the target within the project.
…configuration Resolve the issue causing warnings about non-existing datasources in the Grafana dashboard by ensuring that the UIDs in the datasource definitions match the UIDs specified in the panel configurations. This commit updates the UID values in the Grafana configuration files to align them correctly and eliminate the warnings. Changes: - Update the UID value for the Loki datasource in the datasource.yml file to "a698987a-0cba-42a9-86aa-3ba65104ef72". - Update the UID values for the Loki datasource in the govtool.json file to "a698987a-0cba-42a9-86aa-3ba65104ef72" to match the expected value.
The basicAuth field was unnecessary and redundant under the datasources section in datasource.yml. Removing this field ensures the configuration to always parse and be loaded and establishes a cleaner and more concise configuration file for datasource provisioning in Grafana. Changes: - Removed the basicAuth field that was previously present in the datasources section of datasource.yml. This field was not needed and did not serve any functional purpose. This removal simplifies the configuration file and eliminates redundancy.
drep/list endpoint now returns 2 additional fields (status and type), it returns retired dreps and it allows user to search for given drep by drep name
Developed Nix shell configurations for both frontend and backend modules to streamline the build and deployment processes and ensure alignment with backend setup and dependencies. The new shell configurations provide necessary tools and dependencies for development environments, optimizing the overall development workflow. Changes: - Updated govtool/backend/default.nix to simplify package retrieval using `<nixpkgs>` and removed unnecessary sources file inclusion. - Created govtool/backend/shell.nix to define additional dependencies like awscli, docker, git, and gnumake for the backend module. - Added govtool/frontend/shell.nix to specify frontend module dependencies, ensuring consistency with the backend setup.
…guration-for-frontend [#188] Develop NIX configuration for frontend
…hboard-configuration-datasource-issue [#442] Resolve grafana dashboard configuration datasource issue
…-steps fix/364-information-storage-steps
pmbinapps
requested review from
MSzalowski,
jankun4,
kickloop,
Sworzen1 and
JanJaroszczak
as code owners
Sworzen1
approved these changes
Mar 13, 2024
…e-metadata-from-ui-input [#451] feat: add json&hash generation
add Card atom
MSzalowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
[#188] Introduce yarn2nix based package definition for frontend …
[#188] Prepare Nix shell configuration for frontend and backend …
[#188] Remove outdated Nix configurations for frontend …
[#364] add download icon into download json button
[#365] governance action certs (info and treasury)
[#377, #432] feat: form inputs validation
[#442] Remove redundant basicAuth field from datasource.yml …
[#442] Use the same UID in the datasource definition as in the panel … …
[#446] extend drep/list endpoint …
Other:
add getRewardAddress to builders dependencies
add working logic to GA builders
fix copy for cancel governance action creation
move generateAnchor to untils
Use more descriptive name for the Docker Compose target …