Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle governance action creation in wallet provider #365

Closed
MSzalowski opened this issue Mar 4, 2024 · 2 comments · Fixed by #439
Closed

Handle governance action creation in wallet provider #365

MSzalowski opened this issue Mar 4, 2024 · 2 comments · Fixed by #439
Assignees
@Sworzen1
Labels
🖥 Frontend Frontend related
Milestone
Byron - GA Submit...

Comments

@MSzalowski
Copy link
Contributor

Why

As a user, I want to be able to create a transaction with my Governance Action.

What

Extend wallet provider API to build Governance action transactions.

How

Reference of implementation using CSL - here.
@MSzalowski MSzalowski mentioned this issue Mar 4, 2024
Closed
@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label Mar 4, 2024
@MSzalowski MSzalowski assigned MSzalowski and Sworzen1 and unassigned MSzalowski Mar 6, 2024
Sworzen1 added a commit that referenced this issue Mar 8, 2024
@Sworzen1
[#365] governance action certs (info and treasury)
b43240f
@Sworzen1 Sworzen1 linked a pull request Mar 10, 2024 that will close this issue
feat/365-handle-governance-action-creation-in-wallet-provider #439
Merged
5 tasks
Sworzen1 added a commit that referenced this issue Mar 11, 2024
@Sworzen1
[#365] governance action certs (info and treasury)
1df33ef
@Sworzen1
Copy link
Contributor

its only logic to build gov action @pmbinapps if you want to test it, you can trigger this functions with correct arguments on input and function should return VotingProposalBuilder from CSL as output

@pmbinapps pmbinapps mentioned this issue Mar 12, 2024
Merged
MSzalowski added a commit that referenced this issue Mar 13, 2024
@MSzalowski
Merge pull request #459 from IntersectMBO/develop
008126e 
test: #188, #364, #365, #377, #432, #442, #446 #459
@pmbinapps
Copy link

Works fine GA added, visible in GA list.

Image

@MSzalowski MSzalowski mentioned this issue Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sworzen1 Sworzen1

Labels
🖥 Frontend Frontend related
Projects
Govtool all
Status: Done
Milestone
Byron - GA Submitter - Submit a Gover...
Development

Successfully merging a pull request may close this issue.

feat/365-handle-governance-action-creation-in-wallet-provider IntersectMBO/govtool
3 participants
@MSzalowski @Sworzen1 @pmbinapps