[#188] Develop NIX configuration for frontend #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed obsolete Nix configuration files (default.nix, node-env.nix, and node-packages.nix) from the frontend module. This change is part of a broader effort to update and realign the frontend's build and deployment process with the backend's, ensuring a more streamlined and optimized development environment. The removal of these files paves the way for introducing a revised and more efficient Nix setup that better mirrors the backend's configuration and fulfills the specified acceptance criteria for development environments and dependencies.
This commit introduces a new yarn2nix based package definition for the frontend application. By adding this Nix expression, developers can easily incorporate the project into their nix-shell based environment. Changes: - Added a new file `govtool/frontend/default.nix` that defines the yarn2nix based package configuration for the frontend application "govtool-frontend". This file includes settings for the project name, source directory, package.json file, and yarn.lock file wrapped in the `mkYarnPackage` function, enabling developers to utilize the project seamlessly in their nix-shell based environments.
Developed Nix shell configurations for both frontend and backend modules to streamline the build and deployment processes and ensure alignment with backend setup and dependencies. The new shell configurations provide necessary tools and dependencies for development environments, optimizing the overall development workflow. Changes: - Updated govtool/backend/default.nix to simplify package retrieval using `<nixpkgs>` and removed unnecessary sources file inclusion. - Created govtool/backend/shell.nix to define additional dependencies like awscli, docker, git, and gnumake for the backend module. - Added govtool/frontend/shell.nix to specify frontend module dependencies, ensuring consistency with the backend setup.
placek
requested review from
MSzalowski,
jankun4,
kickloop,
Sworzen1 and
JanJaroszczak
as code owners
MSzalowski
approved these changes
Mar 12, 2024
adgud
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #188.
Purpose of the changes:
The aim of this pull request is to develop Nix configurations for both the frontend and backend modules. This initiative will streamline the build and deployment processes by aligning them with the backend setup and dependencies. The new shell configurations aim to provide the necessary tools and dependencies required for development environments to enhance the overall development workflow.
Outcome of the changes:
This pull request introduces a yarn2nix-based package definition for the frontend application, enabling developers to easily incorporate the project into their nix-shell based environments. In addition, the outdated Nix configuration files for the frontend module have been removed to pave the way for a more efficient Nix setup that better mirrors the backend's configuration. These changes contribute to creating a more streamlined and optimized development environment, fulfilling the specified acceptance criteria for defining development environments and dependencies effectively.