Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance action provider #432

Closed
MSzalowski opened this issue Mar 8, 2024 · 1 comment · Fixed by #445
Closed

Governance action provider #432

MSzalowski opened this issue Mar 8, 2024 · 1 comment · Fixed by #445
Assignees

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Mar 8, 2024

Why

To keep logic of governance action form validation and metadata JSON generation at one place.the

What

Create Governance Action submission provider


Scope of this ticket should include:

  • Governance action provider
  • Governance action type handling - generating governance type schema based on selected type
  • new validators for betch32, decimals and URL

Testing scenario

That issue handles the business logic behind governance action form validation. So that, the only way to test if everything is set correctly is to:

Go to the governance action type selection screen:

  • Check if the selected type has the proper type fields on a form

More changes won't be visible at this point.

@MSzalowski MSzalowski self-assigned this Mar 8, 2024
@MSzalowski MSzalowski linked a pull request Mar 11, 2024 that will close this issue
5 tasks
MSzalowski added a commit that referenced this issue Mar 12, 2024
@pmbinapps
Copy link

OK Theasury:

Image

OK for Info:

Image

OK validation of required one link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants