Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend current DRep list endpoint #223

Closed
MSzalowski opened this issue Feb 19, 2024 · 6 comments · Fixed by #353
Closed

Extend current DRep list endpoint #223

MSzalowski opened this issue Feb 19, 2024 · 6 comments · Fixed by #353
Assignees
@jankun4 @pmbinapps
Labels
⚙ Backend
Milestone
Byron - DRep Expl...

Comments

@MSzalowski
Copy link
Contributor

MSzalowski commented Feb 19, 2024 •
edited
Loading

It should include all the necessary (visible on DRep directory page) information.

Link to figma as reference for the required data
jankun4 added a commit that referenced this issue Feb 29, 2024
@jankun4
[#223] exted drep/list endpoint, and provide voting power
5d3564b 
Signed-off-by: jankun4 <michaljankun@gmail.com>
@jankun4 jankun4 linked a pull request Feb 29, 2024 that will close this issue
[#223] extend drep/list endpoint, and provide voting power #353
Merged
5 tasks
jankun4 added a commit that referenced this issue Mar 4, 2024
@jankun4
[#223] exted drep/list endpoint, and provide voting power
ba7311e 
Signed-off-by: jankun4 <michaljankun@gmail.com>
@SandraRodziewicz SandraRodziewicz mentioned this issue Mar 4, 2024
Merged
SandraRodziewicz added a commit that referenced this issue Mar 4, 2024
@SandraRodziewicz
Merge pull request #381 from IntersectMBO/develop
c86dadb 
test: #320 #350 #351 #223
@pmbinapps pmbinapps self-assigned this Mar 5, 2024
@pmbinapps
Copy link

Currently not all data from design returned as as expected - CLARIFIED:

Image

@MSzalowski
Copy link
Contributor Author

Reference: status should be based on the current DRep status eg.:

isRegisteredAsDRep, wasRegisteredAsDRep and so on for the Sole Voter

@pmbinapps
Copy link

TBC how to define following statuses.
Active
Inactive
retired
no data

@MSzalowski MSzalowski reopened this Mar 6, 2024
@MSzalowski
Copy link
Contributor Author

Reopening an issue as:
Missing status field. Other properties to be defined after CIP-100 submission.

@MSzalowski MSzalowski mentioned this issue Mar 13, 2024
Merged
@pmbinapps
Copy link

Ready for Stage.

Status added: Active, Inactive, Retired

image

pmbinapps added a commit that referenced this issue Mar 13, 2024
@pmbinapps
Merge pull request #460 from IntersectMBO/test
f0f99c6 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
MSzalowski pushed a commit that referenced this issue Mar 19, 2024
@pmbinapps @MSzalowski
Merge pull request #460 from IntersectMBO/test
fa67064 
staging: #351, #350, #320, #223, #317, #385, #358, #359, #151, #358, #360, #110, #379, #382, #361, #362, #446, #188, #377, #432, #364, #451, #433
@MSzalowski
Copy link
Contributor Author

Done & on staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankun4 jankun4

@pmbinapps pmbinapps

Labels
⚙ Backend
Projects
Govtool all
Status: Done
Milestone
Byron - DRep Explorer displays DReps
Development

Successfully merging a pull request may close this issue.

[#223] extend drep/list endpoint, and provide voting power IntersectMBO/govtool
3 participants
@MSzalowski @jankun4 @pmbinapps