Clear up uncertain await safety #6739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-await-rules
branch
2 times, most recently
from
31b48ed
to
494c518
Compare
erights
approved these changes
Dec 31, 2022
packages/agoric-cli/src/deploy.js
Outdated
| @@ -367,12 +371,11 @@ export { bootPlugin } from ${JSON.stringify(absPath)}; | |||
| console.info(`Loading plugin ${JSON.stringify(pluginFile)}`); | |||
| return E.get(E(pluginManager).load(pluginName, pluginOpts)) | |||
| .pluginRoot; | |||
| } catch (e) { | |||
| }).catch(e => { | |||
There was a problem hiding this comment.
Suggested change
| }).catch(e => { | |
| })().catch(e => { |
Uh oh. A hazard of the new approach. Surprised the type checker didn't flag it, since the left operand of the .catch is a function. Any idea why not?
There was a problem hiding this comment.
Typescript checks weren't enabled for this file. It has other type problems that I haven't addressed yet, but are likely outside the scope of this PR.
| await main(bootP, { | ||
| bundleSource: (file, options = undefined) => | ||
| bundleSource(pathResolve(file), options), | ||
| cache, |
There was a problem hiding this comment.
How does dropping cache relate to the other changes of this PR?
There was a problem hiding this comment.
That seems to be a remnant of a drive-by fix I did in my work tree. cache wasn't well-thought-out, and its (invalid) initialisation caused some unhandled rejections that worried our developers. So it's gone for now.
michaelfig
force-pushed
the
mfig-await-rules
branch
from
494c518
to
897a2f8
Compare
michaelfig
added
the
automerge:no-update
michaelfig
force-pushed
the
mfig-await-rules
branch
from
897a2f8
to
3524569
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6226
closes: #6227
closes: #6232
closes: #6233
closes: #6234
closes: #6235
Description
This may serve as a demonstration of idioms to honour the Jessie await rules, most interestingly:
whileloops with nested awaits asfor-await-ofloops with a Jessie-style async generator.trywith nested awaits into an async IIFE with a catch method (await (async () => { ... })().catch(e => { ... })). It's less readable, but much more explicit.Also, I disabled eslint's
no-continuerule for the Agoric SDK.Security Considerations
Documentation Considerations
Testing Considerations