refactor: pulling up more await weeds #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
commented
Jan 3, 2023
erights
commented
Jan 3, 2023
erights
commented
Jan 3, 2023
erights
commented
Jan 3, 2023
| @@ -630,7 +637,7 @@ export default async function startMain(progname, rawArgs, powers, opts) { | |||
| SOLO_COINS, | |||
| ], | |||
| ]; | |||
| for (const cmd of provCmds) { | |||
| for (/* await */ const cmd of provCmds) { | |||
There was a problem hiding this comment.
The await is commented out because
* turning it into a for-await-of loop would legitimize some await in its body
* both a for-await-of loop is not allowed here. This needs repair first.
erights
commented
Jan 3, 2023
michaelfig
reviewed
Jan 3, 2023
michaelfig
reviewed
Jan 3, 2023
michaelfig
reviewed
Jan 3, 2023
michaelfig
approved these changes
Jan 3, 2023
|
This PR only reduces |
erights
added
automerge:squash
erights
force-pushed
the
markm-driveby-await-cleanups
branch
from
c52a653
to
453db21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #6739 to return the favor.
If we keep pulling up the
awaitweeds, we'll eventually be able to turn these warnings into errors.Of the many PRs spawned off from #6219 and the not-yet-written ugly await safety rules at endojs/Jessie#93 , if we just fix 'em, we drop at least some of these kludgy and still-to-be-done workarounds. But this PR is only further incremental progress towards that goal. There are still way too many warnings.
I also refactored the
asyncGeneratechanges from #6739. None of them were interested in providing a value. All were only interested in the stopping condition. So instead@agoric/internalexports three convenience wrappers aroundasyncGenerate:forever,whileTrue, anduntilTrue.I suggest reviewing with "Hide whitespace" on.