Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await safety uncertain in telemetry/src/ingest-slog-entrypoint.js #6234

Closed
erights opened this issue Sep 16, 2022 · 0 comments · Fixed by #6739
Closed

Await safety uncertain in telemetry/src/ingest-slog-entrypoint.js #6234

erights opened this issue Sep 16, 2022 · 0 comments · Fixed by #6739
Assignees
Labels
bug Something isn't working

Comments

@erights
Copy link
Member

erights commented Sep 16, 2022

The triage at #6219 currently classifies this as

  // TODO FIXME This code should be refactored to make this
  // await checkably safe, or to remove it, or to record here
  // why it is actually safe.
  //
  // It is nested in a conditional with no
  // balancing await on the other branch. Likely this is low risk
  // because it is only in telemetry. The integrity of critical computation
  // should not be endangered by a bug in telemetry in any case.

Git blame shows @michaelfig as the one who should probably investigate this, so I'm assigning to them. Feel free to reassign as appropriate of course.

As the comment above indicates, this is likely low risk so I'm omitting the "security" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants