Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await safety uncertain in SwingSet/src/vats/network/network.js in outbound method #6233

Closed
erights opened this issue Sep 16, 2022 · 0 comments · Fixed by #6739
Closed

Await safety uncertain in SwingSet/src/vats/network/network.js in outbound method #6233

erights opened this issue Sep 16, 2022 · 0 comments · Fixed by #6739
Assignees
Labels
bug Something isn't working security

Comments

@erights
Copy link
Member

erights commented Sep 16, 2022

const attempt = await protocolImpl.inbound(

The triage at #6219 currently classifies this as

// TODO FIXME This code should be refactored to make this
// await checkably safe, or to remove it, or to record here
// why it is actually safe.

Git blame shows @michaelfig as the one who should probably investigate this, so I'm assigning to them. Feel free to reassign as appropriate of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants