chore: ensure we return zeroed value when returning errors #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
✅ Deploy Preview for zarf-docs canceled.
|
mkcp
commented
Sep 11, 2024
mkcp
commented
Sep 11, 2024
Codecov ReportAttention: Patch coverage is
|
phillebaba
requested changes
Sep 11, 2024
Signed-off-by: Kit Patella <kit@defenseunicorns.com>
phillebaba
approved these changes
Sep 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mjnagel
pushed a commit
to defenseunicorns/uds-core
that referenced
this pull request
Sep 20, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ghcr.io/zarf-dev/packages/init | minor | `v0.39.0` -> `v0.40.1` | | [zarf-dev/zarf](https://redirect.github.com/zarf-dev/zarf) | minor | `v0.39.0` -> `v0.40.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>zarf-dev/zarf (zarf-dev/zarf)</summary> ### [`v0.40.1`](https://redirect.github.com/zarf-dev/zarf/releases/tag/v0.40.1) [Compare Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.40.0...v0.40.1) #### What's Changed - chore(deps): bump actions/create-github-app-token from 1.10.3 to 1.10.4 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2968 - fix: imported helm overrides by [@​rjferguson21](https://redirect.github.com/rjferguson21) in [zarf-dev/zarf#2967 - chore: only show config file if there is one by [@​catsby](https://redirect.github.com/catsby) in [zarf-dev/zarf#2985 - refactor: trim named returns in pkg [#​2950](https://redirect.github.com/zarf-dev/zarf/issues/2950) by [@​mkcp](https://redirect.github.com/mkcp) in [zarf-dev/zarf#2979 - chore: finish removing named returns outside of package and extensions [#​2950](https://redirect.github.com/zarf-dev/zarf/issues/2950) by [@​mkcp](https://redirect.github.com/mkcp) in [zarf-dev/zarf#2987 - chore: ensure we return zeroed value when returning errors by [@​mkcp](https://redirect.github.com/mkcp) in [zarf-dev/zarf#2988 - chore(deps): bump actions/create-github-app-token from 1.10.4 to 1.11.0 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2991 - refactor: break --insecure into separate flags by [@​joonas](https://redirect.github.com/joonas) in [zarf-dev/zarf#2936 - ci: stop codeql on merge queue by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2934 - fix: add shasum flag and test for https pull by [@​AustinAbro321](https://redirect.github.com/AustinAbro321) in [zarf-dev/zarf#2998 - chore(deps): bump github/codeql-action from 3.26.6 to 3.26.7 by [@​dependabot](https://redirect.github.com/dependabot) in [zarf-dev/zarf#2997 - refactor: pull command by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2989 - docs: update dos-games refs by [@​jasonwashburn](https://redirect.github.com/jasonwashburn) in [zarf-dev/zarf#3004 - refactor: lint by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#3000 - refactor: mirror-resources by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#2975 - fix: gittributes to ignore image file endings by [@​phillebaba](https://redirect.github.com/phillebaba) in [zarf-dev/zarf#3012 #### New Contributors - [@​rjferguson21](https://redirect.github.com/rjferguson21) made their first contribution in [zarf-dev/zarf#2967 - [@​catsby](https://redirect.github.com/catsby) made their first contribution in [zarf-dev/zarf#2985 - [@​mkcp](https://redirect.github.com/mkcp) made their first contribution in [zarf-dev/zarf#2979 - [@​joonas](https://redirect.github.com/joonas) made their first contribution in [zarf-dev/zarf#2936 **Full Changelog**: zarf-dev/zarf@v0.39.0...v0.40.1 ### [`v0.40.0`](https://redirect.github.com/zarf-dev/zarf/compare/v0.39.0...v0.40.0) [Compare Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.39.0...v0.40.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR goes through everything in src (ignoring packager and extensions) and ensures we don't return an error as well as some kind of partial or dirty state from our return vars. Most of these weren't actual vectors for bugs or system instability, it's just good practice. There's some minor cleanups along the way too.
It's worth noting that I used a specific ag command to find error returns (discussed in #2951) so any error variables not starting with
errwill have been missed in this refactor. I expect that there will be very few of these given how err is the convention.I left some review notes which I'll highlight in comments for whoever gets eyes on.
Related Issue
Fixes #2951
Checklist before merging