Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure we return zeroed value when returning errors #2988

Merged
merged 2 commits into from
Sep 11, 2024

fix: apply review comments

2d71bda
Select commit
Loading
Failed to load commit list.
Merged

chore: ensure we return zeroed value when returning errors #2988

fix: apply review comments
2d71bda
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 11, 2024 in 1s

24.36% (-0.02%) compared to 6eeabf9

View this Pull Request on Codecov

24.36% (-0.02%) compared to 6eeabf9

Details

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/cluster/zarf.go 28.57% 4 Missing and 1 partial ⚠️
src/pkg/utils/io.go 0.00% 5 Missing ⚠️
src/cmd/tools/helm/load_plugins.go 0.00% 4 Missing ⚠️
src/pkg/cluster/tunnel.go 0.00% 4 Missing ⚠️
src/pkg/utils/yaml.go 0.00% 3 Missing ⚠️
src/pkg/zoci/pull.go 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/cluster/pvc.go 75.00% <ø> (ø)
src/pkg/transform/artifact.go 90.90% <100.00%> (ø)
src/pkg/utils/yaml.go 0.00% <0.00%> (ø)
src/pkg/zoci/pull.go 0.00% <0.00%> (ø)
src/cmd/tools/helm/load_plugins.go 0.00% <0.00%> (ø)
src/pkg/cluster/tunnel.go 11.78% <0.00%> (-0.05%) ⬇️
src/pkg/cluster/zarf.go 19.19% <28.57%> (+0.01%) ⬆️
src/pkg/utils/io.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes