Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lint #3000

Merged
merged 1 commit into from
Sep 17, 2024
Merged

refactor: lint #3000

merged 1 commit into from
Sep 17, 2024

Conversation

phillebaba
Copy link
Member

Description

Refactor lint command.

Related Issue

Relates to #2969

Checklist before merging

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit b6fad48
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/66e93d2aa044790008d4bc69
😎 Deploy Preview https://deploy-preview-3000--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/lint/lint.go 16.66% 14 Missing and 1 partial ⚠️
src/cmd/dev.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pkg/lint/schema.go 73.68% <ø> (ø)
src/cmd/dev.go 0.00% <0.00%> (ø)
src/pkg/lint/lint.go 43.02% <16.66%> (-2.66%) ⬇️

@phillebaba
Copy link
Member Author

We will not be able to remove os.Chdir until we resolve it in all package composition code, as they assume relative paths. Will revert these changes and only remove the pkg client for now.

Signed-off-by: Philip Laine <philip.laine@gmail.com>
@phillebaba phillebaba marked this pull request as ready for review September 17, 2024 08:28
@phillebaba phillebaba requested review from a team as code owners September 17, 2024 08:28
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillebaba phillebaba added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 3c8dcb8 Sep 17, 2024
27 checks passed
@phillebaba phillebaba deleted the refactor/lint branch September 17, 2024 17:55
mjnagel pushed a commit to defenseunicorns/uds-core that referenced this pull request Sep 20, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| ghcr.io/zarf-dev/packages/init | minor | `v0.39.0` -> `v0.40.1` |
| [zarf-dev/zarf](https://redirect.github.com/zarf-dev/zarf) | minor |
`v0.39.0` -> `v0.40.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>zarf-dev/zarf (zarf-dev/zarf)</summary>

###
[`v0.40.1`](https://redirect.github.com/zarf-dev/zarf/releases/tag/v0.40.1)

[Compare
Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.40.0...v0.40.1)

#### What's Changed

- chore(deps): bump actions/create-github-app-token from 1.10.3 to
1.10.4 by [@&#8203;dependabot](https://redirect.github.com/dependabot)
in
[zarf-dev/zarf#2968
- fix: imported helm overrides by
[@&#8203;rjferguson21](https://redirect.github.com/rjferguson21) in
[zarf-dev/zarf#2967
- chore: only show config file if there is one by
[@&#8203;catsby](https://redirect.github.com/catsby) in
[zarf-dev/zarf#2985
- refactor: trim named returns in pkg
[#&#8203;2950](https://redirect.github.com/zarf-dev/zarf/issues/2950) by
[@&#8203;mkcp](https://redirect.github.com/mkcp) in
[zarf-dev/zarf#2979
- chore: finish removing named returns outside of package and extensions
[#&#8203;2950](https://redirect.github.com/zarf-dev/zarf/issues/2950) by
[@&#8203;mkcp](https://redirect.github.com/mkcp) in
[zarf-dev/zarf#2987
- chore: ensure we return zeroed value when returning errors by
[@&#8203;mkcp](https://redirect.github.com/mkcp) in
[zarf-dev/zarf#2988
- chore(deps): bump actions/create-github-app-token from 1.10.4 to
1.11.0 by [@&#8203;dependabot](https://redirect.github.com/dependabot)
in
[zarf-dev/zarf#2991
- refactor: break --insecure into separate flags by
[@&#8203;joonas](https://redirect.github.com/joonas) in
[zarf-dev/zarf#2936
- ci: stop codeql on merge queue by
[@&#8203;AustinAbro321](https://redirect.github.com/AustinAbro321) in
[zarf-dev/zarf#2934
- fix: add shasum flag and test for https pull by
[@&#8203;AustinAbro321](https://redirect.github.com/AustinAbro321) in
[zarf-dev/zarf#2998
- chore(deps): bump github/codeql-action from 3.26.6 to 3.26.7 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[zarf-dev/zarf#2997
- refactor: pull command by
[@&#8203;phillebaba](https://redirect.github.com/phillebaba) in
[zarf-dev/zarf#2989
- docs: update dos-games refs by
[@&#8203;jasonwashburn](https://redirect.github.com/jasonwashburn) in
[zarf-dev/zarf#3004
- refactor: lint by
[@&#8203;phillebaba](https://redirect.github.com/phillebaba) in
[zarf-dev/zarf#3000
- refactor: mirror-resources by
[@&#8203;phillebaba](https://redirect.github.com/phillebaba) in
[zarf-dev/zarf#2975
- fix: gittributes to ignore image file endings by
[@&#8203;phillebaba](https://redirect.github.com/phillebaba) in
[zarf-dev/zarf#3012

#### New Contributors

- [@&#8203;rjferguson21](https://redirect.github.com/rjferguson21) made
their first contribution in
[zarf-dev/zarf#2967
- [@&#8203;catsby](https://redirect.github.com/catsby) made their first
contribution in
[zarf-dev/zarf#2985
- [@&#8203;mkcp](https://redirect.github.com/mkcp) made their first
contribution in
[zarf-dev/zarf#2979
- [@&#8203;joonas](https://redirect.github.com/joonas) made their first
contribution in
[zarf-dev/zarf#2936

**Full Changelog**:
zarf-dev/zarf@v0.39.0...v0.40.1

###
[`v0.40.0`](https://redirect.github.com/zarf-dev/zarf/compare/v0.39.0...v0.40.0)

[Compare
Source](https://redirect.github.com/zarf-dev/zarf/compare/v0.39.0...v0.40.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/defenseunicorns/uds-core).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants