Use RichText component on Title block #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Updates the gutenberg reference. Update gutenberg submodule (#509) Updates the GB reference. Uses the global store for the post title and adds undo/redo support. # Conflicts: # gutenberg
This was referenced Jan 28, 2019
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Added missing react method signature (#523) passing mediaId in onMediaSelected (#521) v0.3.4 Update GB bundle. Refactor name of MediaSource to avoid name collision on the main app. Update Gutenberg reference. refactor media upload methods to be inline with JS and iOS Refactor names of helper methods. Change media upload sync method. Implement enum using strings to simplify conversion logic. Remove whitespace Refactor method name to make it more obvious the intent. Refactor bridge media protocol methods to a single method. Merge branch 'develop' into feature/media_upload_methods_refactor Refactor media upload names to more consistent names. Removes border from title and changes the placeholder text. passing null to onImageQueryReattach() on Android Implement reattach of events on iOS. Add the ability to set font family, weight, size, and style from RN Recommend using the gutenberg-mobile repo # Conflicts: # gutenberg
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (41 commits) Update gutenberg ref to master Update gutenberg ref Update gutenberg ref to Master Update gutenberg ref Update gutenberg ref Make uploads to be successful. Making sure we will only send a 32 bits number for the media to avoid conversion issues to JS. Implement media actions. Update gutenberg ref Update gutenberg ref Split media pick logic from media upload logic. Updated gutenberg submodule Updated gutenberg submodule Add methods to track ongoing and failed uploads. Updated gutenberg sumodule Updated gutenberg submodule Refactor save to file to separate method. Implement iOS new GB bridge methods for media options. Updated gutenberg submodule Update gutenberg ref ...
Remap font names for iOS for PR 372.
1 task
…rg-mobile into issue/372-move-title-to-rich-text * 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: Make heading styling distinguishable from paragraph (#525) Point to merged Aztec commit Setup Aztec to not autofocus when visible Refocus the last focused item after reattaching Update gutenberg ref to master Update gutenberg ref Fix some issues from merge Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Update gutenberg ref Move callbacks closer to Gutenberg fragment No need to specially set title/content for new post Update android bridge code after merged from develop Ability to attach ReactRootView to different Activity # Conflicts: # gutenberg
…t-again [iOS] Fix the RichText title.
diegoreymendez
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #502 and moves forward #372 by making the title block working fine with the Enter.Key pressed event.
On Enter.Key pressed event, the Keyboard is not dismissed anymore and you can keep writing into the next block.
GB-side PR: WordPress/gutenberg#13548
To test:
Note
With this PR the styling of theTitleblock is lost, we will re-add it back on a separate PR when the iOS side of AztecWrapper will support styling. See this PR here: wordpress-mobile/react-native-aztec#114