Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix the RichText title. #538

Merged

Conversation

diegoreymendez
Copy link
Contributor

Description:

This PR is targeted at a feature branch.

This PR fixes the RichText version of the title for iOS. It also introduces support in RNAztecView for the fontFamily, fontSize and fontWeight props.

The downside of this support is that once you set those props, they override the styling for the whole view.

Testing:

Make sure the title looks fine in iOS. Try editing it, switching to HTML and back.
Make sure the other components still look fine as well.

@diegoreymendez diegoreymendez added this to the Beta milestone Feb 5, 2019
@diegoreymendez diegoreymendez self-assigned this Feb 5, 2019
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daniloercoli daniloercoli merged commit 759d6a1 into issue/372-move-title-to-rich-text Feb 5, 2019
@daniloercoli daniloercoli deleted the try/make-ios-title-great-again branch February 5, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants