Remap font names for iOS for PR 372. #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
|
|
Tests are failing but I've no idea why. Been digging into it without much success so far, so any idea is welcome. |
|
As discussed with @daniloercoli I'm going to go ahead and merge this into his branch, so I can keep working on making the title work fine for iOS, and he can try to figure out why the tests are failing. |
|
I think this PR pretty much addressed #419 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR simply remaps some font names for an open PR so that the work for iOS as well.
iOS unfortunately doesn't support font families
serifandmonospace.Other changes will be needed but these are the basic changes before implementing the iOS native font properties.
Related PRs:
Target PR: #513
Gutenberg PR: WordPress/gutenberg#13628
Testing:
The only testing needed is to make sure the font are good for Android too.