Fix CI for PRs on master #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the binary to execute does not exist in `node_modules/.bin/`, then npx will install the package. In the current setup, that would install @storybook/cli 7.x
guergana
reviewed
Aug 15, 2023
| @@ -57,7 +57,7 @@ jobs: | |||
| run: npm ci | |||
| - name: Build # only runs in case of cache hit, otherwise as part of npm ci | |||
| if: steps.cache.outputs.cache-hit == 'true' | |||
| run: lerna bootstrap | |||
| run: npm run lerna bootstrap | |||
micgro42
changed the title
This was referenced Aug 15, 2023
Merged
chukarave
approved these changes
Aug 16, 2023
micgro42
added a commit
that referenced
this pull request
Aug 16, 2023
This is the equivalent of #688 for the `next` branch. However, here we do not need the chromatic update, because we're already on Chromatic v6.
micgro42
added a commit
that referenced
this pull request
Aug 16, 2023
If that is not explicitly set, CI will use whatever comes with `ubuntu_latest` and that is not what we want for this workflow. Node 14 is consistent with what is used in the other workflows. The PR to upgrade these is #684. This should be merged after #688 and make CI green again on merged branches.
micgro42
added a commit
that referenced
this pull request
Aug 16, 2023
When this action runs, `hashFiles('*/dist')` would always return the empty string, because it does not match any files. That means that the cache key would always be identical: `linux-`.
This should be merged after #688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
ubuntu_latestin the build stepnpx sbwould install the latest version if it is not already in node_modules