Skip to content

Commit

Permalink
Fix cache key for artifact caching (#687)
Browse files Browse the repository at this point in the history
When this action runs, `hashFiles('*/dist')` would always return the empty string, because it does not match any files. That means that the cache key would always be identical: `linux-`.

This should be merged after #688
  • Loading branch information
micgro42 committed Aug 16, 2023
1 parent d480cfa commit 182dac2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test-and-demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
with:
path: |
*/dist
key: ${{ runner.os }}-${{ hashFiles('*/dist') }}
key: ${{ runner.os }}-${{ github.sha }}
- name: Install
if: steps.cache.outputs.cache-hit != 'true'
run: npm ci
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
with:
path: |
*/dist
key: ${{ runner.os }}-${{ hashFiles('*/dist') }}
key: ${{ runner.os }}-${{ github.sha }}
- name: Build Storybooks
run: npm run build:storybook
- name: Deploy Storybook
Expand Down

0 comments on commit 182dac2

Please sign in to comment.