Fix CI for PRs on next #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, CI would use whatever lerna is installed globally, which currently seems to be lerna v7 which no longer has a bootstrap command and thus fails.
If the binary to execute does not exist in `node_modules/.bin/`, then npx will install the package. In the current setup, that would install @storybook/cli 7.x
chukarave
approved these changes
Aug 16, 2023
micgro42
added a commit
that referenced
this pull request
Aug 16, 2023
When this action runs, `hashFiles('*/dist')` would always return the empty string, because it does not match any files. That means that the cache key would always be identical: `linux-`.
This should be merged after #690
Co-authored-by: Guergana Tzatchkova <guergana.tzatchkova@wikimedia.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of #688 for the
nextbranch. However, here we do not need the chromatic update, because we're already on Chromatic v6.