Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cleanup storybook examples and clear warnings #736

Merged
merged 6 commits into from
Jan 6, 2021
Merged

docs: cleanup storybook examples and clear warnings #736

merged 6 commits into from
Jan 6, 2021

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Dec 22, 2020 •
edited
Loading

Summary

Cleanup tasks uncovered as part of #488.

  • Remove mobile stories (those were a workaround before we had the storybook viewport installed)
  • remove deprecated props in our storybook examples (use size enum instead)
  • addParameters is deprecated

This will cause a Happo change since we remove 3 stories.

How To Test

  • Tests run without errors
  • No other Happo changes besides the removed stories.

@haworku haworku added the type: documentation Improvements or additions to documentation label Dec 22, 2020
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Dec 22, 2020 •
edited
Loading

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 2ccd10a

@haworku haworku self-assigned this Dec 22, 2020
ahobson
ahobson approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haworku haworku merged commit 4b0f7aa into main Jan 6, 2021
@haworku haworku deleted the hw-storybook-cleanup branch January 6, 2021 15:56
@brandonlenz brandonlenz mentioned this pull request Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahobson ahobson ahobson approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

@tinyels tinyels Awaiting requested review from tinyels

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

Assignees

@haworku haworku

Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haworku @trussworks-infra-zz @ahobson