Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Make subcomponents handle styles passed in by consumer #488

Closed
haworku opened this issue Sep 30, 2020 · 0 comments · Fixed by #735
Closed

[fix] Make subcomponents handle styles passed in by consumer #488

haworku opened this issue Sep 30, 2020 · 0 comments · Fixed by #735
Labels
type: bug Something isn't working like it's supposed to

Comments

@haworku
Copy link
Contributor

haworku commented Sep 30, 2020

Describe the bug
Some small subcomponents don't allow the consumer to customize the styles further. Originally we thought folks could just pass their own custom subcomponent in these cases. But it has been brought up a few times as a point of frustration or confusion.

This is a small change to make things more usable for others.

Expected Behavior
These components handle a custom className prop and apply it to the base element along with UWSDS classes. We use classnames package to append classes for this type of thing.

Components with the problem:

  • SocialLinks
  • Address
  • MegaMenu
  • Menu
  • NavCloseButton
@haworku haworku added the type: bug Something isn't working like it's supposed to label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant