Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate addParameters and addDecorator #11417

Merged
merged 3 commits into from
Jul 5, 2020

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 4, 2020

Issue: Note on #10005 (comment)

What I did

Deprecated addParameters/addDecorators

How to test

Try offical SB, see now warning. Try other SBs, they will probably warn ;)

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Jul 4, 2020
@tmeasday tmeasday requested a review from shilman July 4, 2020 07:13
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MIGRATION.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants