Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

ROS2 Linting: map_launch #31

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Conversation

jilaada
Copy link
Contributor

@jilaada jilaada commented Dec 18, 2020

Summary

Add linters and missing exec dependencies.

<exec_depend>map_tf_generator</exec_depend>

<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_cmake_cppcheck</test_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jilaada given that this package does not contain any C++, I'd replace this with ament_lint_common, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes should have been made now @esteve!

 - Use ament_lint_common
@jilaada jilaada requested a review from esteve December 22, 2020 09:23
@esteve esteve merged commit 53352c3 into tier4:ros2 Jan 13, 2021
tier4-autoware-private-bot bot pushed a commit that referenced this pull request Sep 14, 2021
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
kosuke55 pushed a commit that referenced this pull request Jul 8, 2022
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants