Squiz/ControlStructureSpacing: bug fix - allow for PHPCS annotation tokens #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okens Treat the new `// phpcs:` comments in the same way as "ordinary" `T_COMMENT` tokens. Includes unit test. Related to 1817, which was recently fixed in a7d4118. This commit builds onto that fix. Without the fix, the `NoLineAfterClose` error would not be reported when there is a `phpcs:` comment after a control structure close brace and the needed fix would not be applied.
|
Thanks 👍 |
jrfnl
deleted the
feature/squiz-controlstructurespacing-phpcs-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat the new
// phpcs:comments in the same way as "ordinary"T_COMMENTtokens.Includes unit test.
Related to #1817, which was recently fixed in a7d4118. This commit builds onto that fix.
Without the fix, the
NoLineAfterCloseerror would not be reported when there is aphpcs:comment after a control structure close brace and the needed fix would not be applied.