Squiz/ClassDeclaration: bug fix - ignore PHPCS annotation tokens #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat the new `// phpcs:` comments in the same way as "ordinary" `T_COMMENT` tokens. Includes adjusted unit test. This fixes a bug where an error would be reported for a `// phpcs:` comment being on the same line as the class close brace, as well as the fixer for that error moving the `// phpcs:` comment, while it shouldn't.
|
The Travis failure is unrelated to this PR. Looks like one of the builds just needs to be restarted. |
|
👍 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat the new
// phpcs:comments in the same way as "ordinary"T_COMMENTtokens.Includes adjusted unit test.
This fixes a bug where an error would be reported for a
// phpcs:comment being on the same line as the class close brace, as well as the fixer for that error moving the// phpcs:comment, while it shouldn't.