Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank line not enforced after control structure if comment on same line as closing brace #1817

Closed
josephzidell opened this issue Dec 28, 2017 · 2 comments
Milestone

Comments

@josephzidell
Copy link
Contributor

josephzidell commented Dec 28, 2017

<?php

$true = true;
if ($true) {
	echo 'hi 1';
}
if ($true) {
	echo 'hi 2';
}//end if
if ($true) {
	echo 'hi 3';
}

Throws an error after the first if, but not after the second. When there's a closing comment, a blank line is not enforced.

This likewise affects foreachs etc...

@gsherwood gsherwood added this to the 3.2.3 milestone Jan 2, 2018
@gsherwood gsherwood changed the title Inconsistent blank line after control structures Blank line not enforced after control structure if comment on same line as closing brace Jan 2, 2018
gsherwood added a commit that referenced this issue Jan 2, 2018
@gsherwood
Copy link
Member

Thanks for reporting this

@josephzidell
Copy link
Contributor Author

Thanks @gsherwood really appreciate the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants