Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't link devices / scan QR #4637

Closed
bartz1 opened this issue Nov 20, 2015 · 66 comments
Closed

Can't link devices / scan QR #4637

bartz1 opened this issue Nov 20, 2015 · 66 comments

Comments

@bartz1
Copy link

bartz1 commented Nov 20, 2015

I am stuck at the step saying "scan the qr code displayed...". I can see the qr code in the camera, but it won't do anything. I'm assuming there should be a moment when the phone goes like "okay I saw that's a qr code", but nothing happens. I think the problem may be that the camera is a bit out of focus.
Samsung galaxy s3, signal 3.5

@bartz1
Copy link
Author

bartz1 commented Nov 20, 2015

I can confirm the problem is that the camera not being in focus. I have the same problem when using the quick direct capture (can't click to focus).
I came to this conclusion after taking a screenshot and zooming -- it linked the device

@2-4601
Copy link
Contributor

2-4601 commented Nov 21, 2015

You might already be aware of this pr #3767 but marking it here as related.

@bartz1
Copy link
Author

bartz1 commented Nov 21, 2015

I don't know if the code that the quick camera uses is the same as the one used by the qr scanner (I haven't looked at the code to be honest) but it seems to be the case.

@ndevln
Copy link

ndevln commented Dec 4, 2015

As in #4804 autofocus is not working when QR Code scanning. I have the same setup:
Signal version: 3.6.1
Android version: 5.1.1 (Cyanogenmod 12.1) snapshot
Device: Samsung Galaxy S2 ("i9100")

@ndevln
Copy link

ndevln commented Dec 4, 2015

Saving the QR-Code png and zoomind doesn't work for me. Even when the QR Code is sharp on the screen, it is not recognized. Also when using Signal 3.7.0, I can scan the Code via an external App and it opens Signal, but in Signal I have to rescan.

@moxie0
Copy link
Contributor

moxie0 commented Dec 4, 2015

@ndevln does it make a difference if you try rotating the device to portrait or landscape?

@HansHerbert
Copy link

No difference for me

Signal version: 3.6.1
Android version: 5.1.1 (Cyanogenmod 12.1)
Device: Samsung Galaxy S2 ("i9100")

@ndevln
Copy link

ndevln commented Dec 5, 2015

No makes no difference. Also moving the QR Code in from all sides makes no difference (in portrait and landscape mode). Also I can't take pictures with my back camera in the messaging view (but i can see the preview). My front camera works in the quick camera mode (autofocus and capturing pictures). I think using the front camera for the qr code scan would work, but it's still only a workaround.

@lolonaut
Copy link

lolonaut commented Dec 5, 2015

Same situation here, Signal doesn't focus and the QR code won't get recognized (zoomed screenshot or switching between landscape/portrait doesn't help).

Signal version: 3.6.1
Android: 5.1.1 (Cyanogenmod 12.1)
Device: Galaxy S2 (i9100)

@JStyle21
Copy link

JStyle21 commented Dec 5, 2015

+1 to this issue it's the same as described by me in #4661.

@lolonaut
Copy link

lolonaut commented Dec 5, 2015

Apart from the camera issue, what speaks against manual device linking (e.g. via typing of a code)?
Would be a workaround for this case and the only option for people with broken cameras (or even smartphones without a camera)...

@JStyle21
Copy link

JStyle21 commented Dec 6, 2015

lolonaut, couldn't agree more!

@ndevln
Copy link

ndevln commented Dec 6, 2015

I think it's not quite as simple as that, since this function allows you to get a full take an the devices communication over Signal. For example the verification of the fingerprint of your contacts is done by an external app (f-droid barcode scanner in my case). But for this scan they use an internal approach, which I think is a deliberate choice.

Secure design is hard to get right and I think @moxie0 has put some thought into it.

@lolonaut
Copy link

lolonaut commented Dec 6, 2015

I'm not sure if I understand you right...my suggestion would be to show the QR-code data (i.e. the uuid and the ub_key) underneath the QR-code-field in the chrome app and to add a manual linking option into the smartphone app, where one could type the uuid and the ub_key by hand.
Would this really be less secure?

@HansHerbert
Copy link

I don't see why this should be less secure. The format of the data shouldn't have any impact on the security.

@abcdev
Copy link

abcdev commented Dec 14, 2015

There seems to be a very strange bug within the auto focus behavior of the Samsung Galaxy S2 (other devices may be affected too).

The CameraView class checks the supported focusModes (on the S2 both FOCUS_MODE_CONTINUOUS_PICTURE and FOCUS_MODE_CONTINUOUS_VIDEO are reported back as supported by camera.getParameters()) and sets them if available. This alone should trigger continuous auto focus but it doesn't on this device.

So AFAIK the only solution is invoking camera.autoFocus() reasonably often enough between startPreview() and before stopPreview().

Signal version: 3.6.1
Android: 5.1.1 (Cyanogenmod 12.1)
Device: Galaxy S2 (i9100)

@2-4601 2-4601 changed the title Can't link devices Can't link devices / scan QR (Galaxy S2 camera issue) Dec 17, 2015
@nerdoc
Copy link

nerdoc commented Dec 22, 2015

I also can confirm this issue on my S2.

What I want to add is that the QR scanner from the (open source) "Barcode scanner" com.google.zxing.client.android does work perfectly, while signal's implementation does not.

Signal version: 3.7.2
Android version: 5.1.1 (Cyanogenmod 12.1) snapshot
Device: Samsung Galaxy S2 ("i9100")

@JStyle21
Copy link

This is exactly what happens and the reason i've opened my issue(referenced above).
I've also tried several QR scanners and all of them worked as well but since the link process stopped using a URL and switched to an internal scanner it stopped working for me.
Please address this problem with some priority as it related to basic functionality (even tho it's still in beta).

@lukeIam
Copy link

lukeIam commented Dec 22, 2015

The preview image looks sharp, but it es not recognized 😞
Edit: S2 CM12.1

@raubv0gel
Copy link

Same issue here.

@MonsterCode8000
Copy link

Same issue here, with the XCover2 (GT-S7710) Android- Version 4.1.2.

@ngulden
Copy link

ngulden commented Jan 27, 2016

Same issue with Galaxy S2 and CM 12.1.

@neurotensin
Copy link

Hi, I posted in desktop signalapp/Signal-Desktop#665 issues too, so this is probably belongs here:
https://gist.github.com/anonymous/299d4e71409a231f5396

@borowitz
Copy link

borowitz commented Jul 4, 2016

Same issue here signal 3.16.0. It did work when I took a screenshot and zoomed in on it.

@SeIek
Copy link

SeIek commented Jul 29, 2016

I switched to SlimSaber 4.4.4 on my SGS 2 and it works. So it most likely has to do with how Cyanogenmod handles it.

@lukeIam
Copy link

lukeIam commented Aug 20, 2016

I tired cm-13.0-20160818-NIGHTLY on my S2 and it is working! 👍
The code is recognized in under a second.

Looks like CyanogenMod/android_device_samsung_galaxys2-common@b7fa70d did the trick.

@nerdoc
Copy link

nerdoc commented Aug 22, 2016

I cant confirm that any more, as I don't use GApps any more, therefore Signal is not working on my device and I had to remove it. Sorry about that, but unless #127 is not fixed, I'm not able to use Signal...

@JacobHenner
Copy link

Experiencing this on CM 13, neither the QR scanning nor the in-chat camera feature starts the camera. All other apps using camera (e.g. facebook messenger) seem to work.

@Integral
Copy link

Integral commented Nov 7, 2016

Worked for me couple months ago after making screenshot, zooming in and rotating. But now it's not working anymore (during last month). Lenovo s856, debug log: https://gist.github.com/anonymous/3c24d13861f97632cce7b2f08c50b53c

@spacekookie
Copy link

Personally I've not had issues with it. BUT two of my friends are experiencing this issue. It seems to be that the camera isn't focusing properly.

Happening with a Samsung GT-S7580.

Anything that might help fix this? (haven't read the entire thread)

@lpirl
Copy link

lpirl commented Nov 16, 2016

@spacekookie please do read the thread and save everyone's time (try phone in landscape or moving it from real close to far away slowly in the hope the QR is in focus at some point).

@merkste
Copy link

merkste commented Dec 1, 2016

I have troubles scanning QR codes as well. It seems to be a general focusing problem of the in-app camera, as described in #5276. None of the workarounds mentioned above help. If a QR code is successfully scanned, it seem to happen by chance.

@emalstm
Copy link

emalstm commented Jan 11, 2017

I too have the problem which I suspect is due to the back camera of my Nexus 5X being a bit broken. It can't focus and so I can't pair new devices. Same goes for Whatsapp (which uses the same underlying protocol).

@riyapenn
Copy link

One user has had success taking a screenshot of the QR code, zooming in, and using the phone camera to scan.

Again, I'm suggesting you

  1. Take a screen shot on your computer of Signal Desktop with the QR code
  2. Open the screen shot image in an image viewer i.e. MS Paint
  3. Zoom in on the image
  4. Take your phone and scan the "zoomed-in QR code"

@emalstm
Copy link

emalstm commented Jan 13, 2017

@riyapenn it worked!

@bengoldstein
Copy link

Uh, I had this problem. Tried various things, including printing the QR code and it still didn't work. I futzed with camera settings because no matter what I did it was blurry. Then I looked at the lens and noticed schmutz on it. I cleaned that off and presto, no problem. Duh.

@timbury
Copy link

timbury commented Feb 5, 2017

I have this same issue on my Sprint HTC One m7 (camera sucks but is functioning). If I use a generic barcode scanning app, it scans it immediately but that is no help authenticating in Signal. It does show, however, there is no problem with the camera's focus, functionality or cleanliness. Any idea of the scope of this issue? Is this affecting most users? Some? Few? Seems to me it is a critical bug if the scope is broad enough.

@spacebast
Copy link

Same with Galaxy Xcover 2 (GT-S7710, quite similiar to S2), Vanir AOSP Android 4.4.4:
No image if i want to read the QR-code, seems like no access to the cam. Otherwise no problem with taking photos from the chat directly or using the camera with other apps.
Log:
https://gist.github.com/anonymous/5d7331deacd821b0f6246d3dc36fdf6a

@Lesik
Copy link

Lesik commented Feb 17, 2017

I am using a Nexus S with Android 4.4.4 (CM 11) and am having the same issue, due to the QR code being out of focus. The WhatsApp app is constantly refocusing, but Signal does nothing.

The workaround (screencapping the QR code, then enlarging it in GIMP) solved the issue, but this isn't a suitable workaround for newbies, which is who the app is mainly targeted towards.

@0x7969
Copy link

0x7969 commented Mar 2, 2017

I copied the workaround provided by f41c0r (see above) to a fork of the current Signal (his original workaround was applied to WebSocket LibreSignal), as this was still not working on my Xperia M with latest Lineage OS: https://github.com/ypsy/Signal-Android

Works fine now for me! You have to scan the code using an external app and then enter the link into signal manually.

Disclaimer: I really have no clue about all this, just reproduced the changes made by f41c0r, who originally wrote the workaround. If there's anything I did wrong, let me know.

@ngulden
Copy link

ngulden commented Mar 13, 2017

I no longer observe this issue on my Samsung Galaxy SII (GT-I9100) running LineageOS 14.1-20170307-NIGHTLY (Android 7.1.1) and Signal 3.30.4.

@0x7969
Copy link

0x7969 commented Apr 27, 2017

Still not working for me on Sony Xperia M (nicki) with newest Lineage OS (build from 20.04.17) and a fresh install of the latest Signal.

@skom91
Copy link

skom91 commented Apr 28, 2017

Also same for me in Xperia M same Lineage OS.
Barcode scanner com.google.zxing.client.android is working fine, camera, focus, everyting else too, just the in app scanner is not able to scan the QR-Code even if its focused.
A Workaround solution like that would also be fine:
#5538
This would also solve Problems with Broken Cameras for example.

@SergeBouchut
Copy link

SergeBouchut commented May 11, 2017

Same problem on Sony Xperia M C1905 with LineageOS 14.1 (nicki 2017-04-27) and latest Signal 4.5.3.

@hundertsieben
Copy link

The smartphone I'm using has a really bad camera and won't scan the code. Not even in a QR code scanner. I tried enlarging the picture and I tried cleaning the lense. I'm stuck. And a bit pissed that Signal obviously wants me to be a wealthy person to use all of its features.

@kousu
Copy link

kousu commented Aug 7, 2017

I have a MotoE first gen whose camera is pretty good but has zero ability to focus, and I cannot link devices. After reading this thread, the take-a-screenshot-and-zoom trick worked for me, but it seems kludgy.

A lot of smartphones are cheap and will never be able to scan a dense QR code properly.

If #5538 isn't going to be merged, what if that workaround was at least documented in the FAQ?

@MarcelNehring
Copy link

What is the official comment on this issue?

Samsung Galaxy S 2 (GT-I9100) with Lineage OS 14.1.20171101-NIGHTLY-i9100 here and no way to link devices. The screenshot & zoom-in workaround does also not work. Other QR code apps recognize the code without problems.

@Patribu
Copy link

Patribu commented Jan 2, 2018

Hello,
I started a post with regard to this issue somewhere else,
https://whispersystems.discoursehosting.net/t/my-smartphone-does-not-scan-the-qr-code-for-desktop-installation/1794/6
but someone called my attention to this thread.

I'm having the same issue. Nothing works, also none of the proposed methods above.
My phone is a Sony Xperia M C2905, QR code scanning works with any other applications, only Signal is not working.

I hope there is a stable solution to this soon, since I need Signal on my desktop environment.

@automated-signal
Copy link

GitHub Issue Cleanup:
See #7598 for more information.

@signalapp signalapp locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests