-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't link devices / scan QR #4637
Comments
I can confirm the problem is that the camera not being in focus. I have the same problem when using the quick direct capture (can't click to focus). |
You might already be aware of this pr #3767 but marking it here as related. |
I don't know if the code that the quick camera uses is the same as the one used by the qr scanner (I haven't looked at the code to be honest) but it seems to be the case. |
As in #4804 autofocus is not working when QR Code scanning. I have the same setup: |
Saving the QR-Code png and zoomind doesn't work for me. Even when the QR Code is sharp on the screen, it is not recognized. Also when using Signal 3.7.0, I can scan the Code via an external App and it opens Signal, but in Signal I have to rescan. |
@ndevln does it make a difference if you try rotating the device to portrait or landscape? |
No difference for me Signal version: 3.6.1 |
No makes no difference. Also moving the QR Code in from all sides makes no difference (in portrait and landscape mode). Also I can't take pictures with my back camera in the messaging view (but i can see the preview). My front camera works in the quick camera mode (autofocus and capturing pictures). I think using the front camera for the qr code scan would work, but it's still only a workaround. |
Same situation here, Signal doesn't focus and the QR code won't get recognized (zoomed screenshot or switching between landscape/portrait doesn't help). Signal version: 3.6.1 |
+1 to this issue it's the same as described by me in #4661. |
Apart from the camera issue, what speaks against manual device linking (e.g. via typing of a code)? |
lolonaut, couldn't agree more! |
I think it's not quite as simple as that, since this function allows you to get a full take an the devices communication over Signal. For example the verification of the fingerprint of your contacts is done by an external app (f-droid barcode scanner in my case). But for this scan they use an internal approach, which I think is a deliberate choice. Secure design is hard to get right and I think @moxie0 has put some thought into it. |
I'm not sure if I understand you right...my suggestion would be to show the QR-code data (i.e. the uuid and the ub_key) underneath the QR-code-field in the chrome app and to add a manual linking option into the smartphone app, where one could type the uuid and the ub_key by hand. |
I don't see why this should be less secure. The format of the data shouldn't have any impact on the security. |
There seems to be a very strange bug within the auto focus behavior of the Samsung Galaxy S2 (other devices may be affected too). The CameraView class checks the supported focusModes (on the S2 both FOCUS_MODE_CONTINUOUS_PICTURE and FOCUS_MODE_CONTINUOUS_VIDEO are reported back as supported by camera.getParameters()) and sets them if available. This alone should trigger continuous auto focus but it doesn't on this device. So AFAIK the only solution is invoking camera.autoFocus() reasonably often enough between startPreview() and before stopPreview(). Signal version: 3.6.1 |
I also can confirm this issue on my S2. What I want to add is that the QR scanner from the (open source) "Barcode scanner" Signal version: 3.7.2 |
This is exactly what happens and the reason i've opened my issue(referenced above). |
The preview image looks sharp, but it es not recognized 😞 |
Same issue here. |
Same issue here, with the XCover2 (GT-S7710) Android- Version 4.1.2. |
Same issue with Galaxy S2 and CM 12.1. |
Hi, I posted in desktop signalapp/Signal-Desktop#665 issues too, so this is probably belongs here: |
Same issue here signal 3.16.0. It did work when I took a screenshot and zoomed in on it. |
I switched to SlimSaber 4.4.4 on my SGS 2 and it works. So it most likely has to do with how Cyanogenmod handles it. |
I tired cm-13.0-20160818-NIGHTLY on my S2 and it is working! 👍 Looks like CyanogenMod/android_device_samsung_galaxys2-common@b7fa70d did the trick. |
I cant confirm that any more, as I don't use GApps any more, therefore Signal is not working on my device and I had to remove it. Sorry about that, but unless #127 is not fixed, I'm not able to use Signal... |
Experiencing this on CM 13, neither the QR scanning nor the in-chat camera feature starts the camera. All other apps using camera (e.g. facebook messenger) seem to work. |
Worked for me couple months ago after making screenshot, zooming in and rotating. But now it's not working anymore (during last month). Lenovo s856, debug log: https://gist.github.com/anonymous/3c24d13861f97632cce7b2f08c50b53c |
Personally I've not had issues with it. BUT two of my friends are experiencing this issue. It seems to be that the camera isn't focusing properly. Happening with a Samsung GT-S7580. Anything that might help fix this? (haven't read the entire thread) |
@spacekookie please do read the thread and save everyone's time (try phone in landscape or moving it from real close to far away slowly in the hope the QR is in focus at some point). |
I have troubles scanning QR codes as well. It seems to be a general focusing problem of the in-app camera, as described in #5276. None of the workarounds mentioned above help. If a QR code is successfully scanned, it seem to happen by chance. |
I too have the problem which I suspect is due to the back camera of my Nexus 5X being a bit broken. It can't focus and so I can't pair new devices. Same goes for Whatsapp (which uses the same underlying protocol). |
One user has had success taking a screenshot of the QR code, zooming in, and using the phone camera to scan. Again, I'm suggesting you
|
@riyapenn it worked! |
Uh, I had this problem. Tried various things, including printing the QR code and it still didn't work. I futzed with camera settings because no matter what I did it was blurry. Then I looked at the lens and noticed schmutz on it. I cleaned that off and presto, no problem. Duh. |
I have this same issue on my Sprint HTC One m7 (camera sucks but is functioning). If I use a generic barcode scanning app, it scans it immediately but that is no help authenticating in Signal. It does show, however, there is no problem with the camera's focus, functionality or cleanliness. Any idea of the scope of this issue? Is this affecting most users? Some? Few? Seems to me it is a critical bug if the scope is broad enough. |
Same with Galaxy Xcover 2 (GT-S7710, quite similiar to S2), Vanir AOSP Android 4.4.4: |
I am using a Nexus S with Android 4.4.4 (CM 11) and am having the same issue, due to the QR code being out of focus. The WhatsApp app is constantly refocusing, but Signal does nothing. The workaround (screencapping the QR code, then enlarging it in GIMP) solved the issue, but this isn't a suitable workaround for newbies, which is who the app is mainly targeted towards. |
I copied the workaround provided by f41c0r (see above) to a fork of the current Signal (his original workaround was applied to WebSocket LibreSignal), as this was still not working on my Xperia M with latest Lineage OS: https://github.com/ypsy/Signal-Android Works fine now for me! You have to scan the code using an external app and then enter the link into signal manually. Disclaimer: I really have no clue about all this, just reproduced the changes made by f41c0r, who originally wrote the workaround. If there's anything I did wrong, let me know. |
I no longer observe this issue on my Samsung Galaxy SII (GT-I9100) running LineageOS 14.1-20170307-NIGHTLY (Android 7.1.1) and Signal 3.30.4. |
Still not working for me on Sony Xperia M (nicki) with newest Lineage OS (build from 20.04.17) and a fresh install of the latest Signal. |
Also same for me in Xperia M same Lineage OS. |
Same problem on Sony Xperia M C1905 with LineageOS 14.1 (nicki 2017-04-27) and latest Signal 4.5.3. |
The smartphone I'm using has a really bad camera and won't scan the code. Not even in a QR code scanner. I tried enlarging the picture and I tried cleaning the lense. I'm stuck. And a bit pissed that Signal obviously wants me to be a wealthy person to use all of its features. |
I have a MotoE first gen whose camera is pretty good but has zero ability to focus, and I cannot link devices. After reading this thread, the take-a-screenshot-and-zoom trick worked for me, but it seems kludgy. A lot of smartphones are cheap and will never be able to scan a dense QR code properly. If #5538 isn't going to be merged, what if that workaround was at least documented in the FAQ? |
What is the official comment on this issue? Samsung Galaxy S 2 (GT-I9100) with Lineage OS 14.1.20171101-NIGHTLY-i9100 here and no way to link devices. The screenshot & zoom-in workaround does also not work. Other QR code apps recognize the code without problems. |
Hello, I'm having the same issue. Nothing works, also none of the proposed methods above. I hope there is a stable solution to this soon, since I need Signal on my desktop environment. |
GitHub Issue Cleanup: |
I am stuck at the step saying "scan the qr code displayed...". I can see the qr code in the camera, but it won't do anything. I'm assuming there should be a moment when the phone goes like "okay I saw that's a qr code", but nothing happens. I think the problem may be that the camera is a bit out of focus.
Samsung galaxy s3, signal 3.5
The text was updated successfully, but these errors were encountered: