-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate all tagged functors in GMLS class into separate structs/functors #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched ComputePrestencil functor to use this struct for non-member function calls to GMLS
- Removed getNNeighbors and getMaxNNeighbors from GMLS class, now everything uses neighbor lists directly to get this information - Changed Compadre_GMLS_Basis.hpp to Compadre_Basis.hpp, as its assembly routines are more general than GMLS - Modified all other parts of GMLS calls to Basis functionality to agree with functions external to the GMLS class
…using GMLSBasisData
- Private variables needing copied are handled by their data struct being friended to the GMLS class
- Also reorganized GMLSBasisData struct members
Addresses issue #253 |
Removes G_inv #255 |
…eRank - Did the same for TargetOutputTensorRank - Reason for change is that 11.3 of cuda doesn't recognize constexpr int array is accessible from device
- Removed GMLS destructor (not needed)
… version included)
- If not set to zero, possible to be read in and used by Evaluator uninitialized (NaNs)
kuberry
force-pushed
the
separate_functors
branch
from
October 31, 2021 02:05
12f104d
to
7a95fd6
Compare
This was referenced Oct 31, 2021
- All functors extracted from GMLS class - Add SolutionSet struct - Add PointConnections struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.