Add PointData class and use it in GMLS class #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
view, same memory space but different layout, and different memory space.
_target_point_data.getCoordinateDevice().
PointData class. Added instances of different constructions to UtilityTest.cpp
PointData class. Added example to UtilityTest.cpp
for PointData class for same template. Details now mention that with same template, it is a shallow copy, while when templates are different, it is a deep copy.
|
This is the beginning of addressing issue #215 |
or target coordinates. Data flow management in PointData is now analagous to Tpetra's way of marking for fill and completion, except ours is now done by device/host with resumeFillOnHost, resumeFillOnDevice, fillCompleteOnHost, and fillCompleteOnDevice. This prevents the host and device from ever getting out of sync. Switched GMLS_Device test over to using new PointData structures in the example, with filling of source coordinate data no host and target coordinate data on device. Not complete yet, as KDtree search calls in PointCloudSearch still require access to Kokkos view.
Switch PointCloudSearch over to using PointData for trg_pts. Passes tests on Cuda w/wo UVM.
and target coordinates before setting problem data for GMLS class. Switched PointCloudSearch over to using PointData rather than a raw Kokkos view and additionally it is now a const reference object.
is not modified by user between subsequent calls.
|
This PR was to treat point data like the neighbor list accessor class (managing host and device views). Instead, a struct of type PointConnections replaced GMLS class managing source and target coordinates as Kokkos views in #257. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.