Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade @web3-onboard/core #34

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: upgrade @web3-onboard/core #34

merged 1 commit into from
Jun 29, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves key.pairing error in console (as in saw-wallet-web)

How this PR fixes it

@web3-onboard/core has been updated, which includes the latest versions of all WC packages and the fix for the reported issue.

How to test it

Connect to the app with a Safe via WC and observe no errors in either console.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Branch preview

✅ Deploy successful!

https://fix_keypairing--governance.review-react-br.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook
Copy link
Member Author

As the same change was QA'd in safe-wallet-web, I'm going to merge this directly.

@iamacook iamacook merged commit cd90c2a into dev Jun 29, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
@iamacook iamacook deleted the fix-keypairing branch July 4, 2023 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants