Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pairingTopic undefined #2684

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: pairingTopic undefined #2684

merged 1 commit into from
Jun 19, 2023

Conversation

ganchoradkov
Copy link
Member

@ganchoradkov ganchoradkov commented Jun 19, 2023

Description

Added a check that session.pairingTopic exists before attempting to clean up duplicate pairings as older SDK versions do not have this prop

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

dogfooding
tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • [] Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Jun 19, 2023
@ganchoradkov ganchoradkov self-assigned this Jun 19, 2023
@ganchoradkov ganchoradkov added the type: bug Something isn't working label Jun 19, 2023
Copy link
Contributor

@ignaciosantise ignaciosantise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants