Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade @web3-onboard/core #2195

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: upgrade @web3-onboard/core #2195

merged 1 commit into from
Jun 29, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2137

How this PR fixes it

@web3-onboard/core has been updated, which includes the latest versions of all WC packages and the fix for the reported issue.

How to test it

  1. Open two Safes in separate windows.
  2. Connect to one from the other via WC.
  3. Observe no errors in either console.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh June 28, 2023 15:29
@iamacook iamacook self-assigned this Jun 28, 2023
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Branch preview

✅ Deploy successful!

https://fix_key_pairing--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM, the error reported doesn't show anymore

@iamacook iamacook merged commit 52faa41 into dev Jun 29, 2023
7 checks passed
@iamacook iamacook deleted the fix-key-pairing branch June 29, 2023 07:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WC v2 - key.pairing error in console
3 participants