Add some UI tests and reword error-code docs #106557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
I think that I'll have some more of these coming so tell me what size PRs you want. |
| no_longer_emitted_codes.push(err_code.to_owned()); | ||
| verbose_print!( |
Like this is fine for me. Thanks for working on this! |
Ezrashaw
force-pushed
the
ui-test-fixups-1
branch
from
34868d4
to
ae61c25
Compare
GuillaumeGomez
approved these changes
Jan 8, 2023
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez |
bors
added
S-waiting-on-bors
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 8, 2023
…aumeGomez Add some UI tests and reword error-code docs Added UI tests for `E0013` and `E0015`. Error code docs for `E0015` were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit. I also fixed up some issues in the new `error_codes.rs` tidy check (linked rust-lang#106341), that I overlooked previously. r? `@GuillaumeGomez`
This was referenced Jan 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#103104 (Stabilize `main_separator_str`) - rust-lang#106410 (Suggest `mut self: &mut Self` for `?Sized` impls) - rust-lang#106457 (Adjust comments about pre-push.sh hook) - rust-lang#106546 (jsondoclint: Check local items in `paths` are also in `index`.) - rust-lang#106557 (Add some UI tests and reword error-code docs) - rust-lang#106562 (Clarify examples for `VecDeque::get/get_mut`) - rust-lang#106580 (remove unreachable error code `E0313`) - rust-lang#106581 (Do not emit wrong E0308 suggestion for closure mismatch) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UI tests for
E0013andE0015. Error code docs forE0015were a bit unclear (they referred to all non-const errors in const context, when only non-const functions applied), so I touched them up a bit.I also fixed up some issues in the new
error_codes.rstidy check (linked #106341), that I overlooked previously.r? @GuillaumeGomez