Suggest mut self: &mut Self for ?Sized impls
#106410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Jan 3, 2023
|
@bors r+ rollup |
|
📌 Commit b40533999d808946faf2f325e11eb833a1ac49a9 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
Actually..... hm.... This is very likely not what the user wants, to the point that I think the suggestion may be misleading... Let me think about this a bit. @bors r- |
bors
added
S-waiting-on-author
|
Might it be more helpful here to suggest adding a |
|
I would probably avoid doing any suggestion here, and explaining that |
clubby789
force-pushed
the
borrow-mut-self-mut-self-diag
branch
from
b405339
to
6f97993
Compare
|
I'm not entirely sure here about the wording, or if @rustbot ready |
rustbot
added
S-waiting-on-review
klensy
reviewed
Jan 5, 2023
clubby789
force-pushed
the
borrow-mut-self-mut-self-diag
branch
from
6f97993
to
23c3a30
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Jan 8, 2023
…-diag, r=compiler-errors Suggest `mut self: &mut Self` for `?Sized` impls Closes rust-lang#106325 Closes rust-lang#93078 The suggestion is _probably_ not what the user wants (hence `MaybeIncorrect`) but at least makes the problem in the above issues clearer. It might be better to add a note explaining why this is the case, but I'm not sure how best to word that so this is a start. `@rustbot` label +A-diagnostics
This was referenced Jan 8, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2023
Rollup of 8 pull requests Successful merges: - rust-lang#103104 (Stabilize `main_separator_str`) - rust-lang#106410 (Suggest `mut self: &mut Self` for `?Sized` impls) - rust-lang#106457 (Adjust comments about pre-push.sh hook) - rust-lang#106546 (jsondoclint: Check local items in `paths` are also in `index`.) - rust-lang#106557 (Add some UI tests and reword error-code docs) - rust-lang#106562 (Clarify examples for `VecDeque::get/get_mut`) - rust-lang#106580 (remove unreachable error code `E0313`) - rust-lang#106581 (Do not emit wrong E0308 suggestion for closure mismatch) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106325
Closes #93078
The suggestion is probably not what the user wants (hence
MaybeIncorrect) but at least makes the problem in the above issues clearer. It might be better to add a note explaining why this is the case, but I'm not sure how best to word that so this is a start.@rustbot label +A-diagnostics