Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Export pluginlib to downstream packages (#113) #144

Merged
merged 1 commit into from
Jul 29, 2019
Merged

[Backport] Export pluginlib to downstream packages (#113) #144

merged 1 commit into from
Jul 29, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Jul 26, 2019

Signed-off-by: Esteve Fernandez esteve@apache.org

@esteve @hidmic
Export pluginlib to downstream packages (#113)
2843328 
Signed-off-by: Esteve Fernandez <esteve@apache.org>
@hidmic
Copy link
Contributor Author

hidmic commented Jul 26, 2019

Running CI up to rosbag2 against dashing:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Jul 29, 2019

@nuclearsandwich this PR went through the PR job plus a CI against dashing. Do you think we should run another CI against dashing-release or can we let this one in already?

@nuclearsandwich
Copy link
Member

Do you think we should run another CI against dashing-release or can we let this one in already?

I think it's fine to go ahead. At this point the dashing branch better reflects the upcoming patch 2 release than dashing-release does.

@hidmic hidmic merged commit 32612a0 into dashing Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the dashing_backport_113 branch July 29, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hidmic @nuclearsandwich @Karsten1987 @ivanpauno @esteve