Convert CDR to ROS 2 #16
Comments
Martin-Idel-SI
added a commit
to bosch-io/rosbag2
that referenced
this issue
Oct 25, 2018
Martin-Idel-SI
added a commit
to bosch-io/rosbag2
that referenced
this issue
Oct 25, 2018
- Easier to differentiate between storage format (e.g. sqlite) and serialization format (e.g. cdr) - Closer to naming in ros middleware
Martin-Idel-SI
added a commit
to bosch-io/rosbag2
that referenced
this issue
Oct 25, 2018
- Also adapt to name changes
Martin-Idel-SI
added a commit
to bosch-io/rosbag2
that referenced
this issue
Oct 25, 2018
Karsten1987
pushed a commit
that referenced
this issue
Oct 26, 2018
* GH-101 Add converter interface * GH-102 Create format converter factory * GH-103 Write documentation for converter plugin authors * GH-16 Adjust rosbag2 message type * GH-16 Change name of converter interface to include "serialization" - Easier to differentiate between storage format (e.g. sqlite) and serialization format (e.g. cdr) - Closer to naming in ros middleware * GH-16 Improve plugin development documentation - Also adapt to name changes * GH-16 Fix naming of SerializationFormatConverterFactory
agalbachicar
added a commit
to agalbachicar/rosbag2
that referenced
this issue
Mar 25, 2022
agalbachicar
added a commit
to agalbachicar/rosbag2
that referenced
this issue
Apr 25, 2022
* Adresses reviewer's comments. * Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions() - Reduces test_play_for execution time from 50s to 6s approximately. Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
MichaelOrlov
added a commit
that referenced
this issue
Jun 2, 2022
* Add play-for functionality Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add play-for to the CLI Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Solves most of the comments from https://github.com/ros2/rosbag2/pull/960/files (#14) * Add play-for functionality Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add play-for to the CLI Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Adds playback_duration to PlayOptions. * Changes from PlayFor to Play srv message and changes start_offset and playback_duration. * Restores play_for tests. * Removes extra SubscriptionManager methods. * Solves comment about extra sent message. * Reorders code and comment. * Removes the SKIP_TEST flag. Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Second round of comments from #960 upstream (#15) * Removes duration parameter. A leftover after switching to playback_duration. * Fixes comment. * Solves format in rosbag2_py -> _transport.cpp * Applies style suggestions. * Changes play() to return a boolean indicating whether the request could be fulfilled. * Removes extra unnecessary code. Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Updates test execution time for #960 (#16) * Adresses reviewer's comments. * Improve test time by adding an optional argument to SubscriptionManager::spin_subscriptions() - Reduces test_play_for execution time from 50s to 6s approximately. Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Redesign tests in test_play_for.cpp (#17) * Redesigned tests to be more deterministic and running faster * Fixed bug in `play_for()` flow when replaying in loop or multiple times from the same player instance. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove unnecessary source file from test binary Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct errors introduced by rebase Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct play_next behaviour Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Agustin Alba Chicar <ag.albachicar@ekumenlabs.com> Co-authored-by: Michael Orlov <morlovmr@gmail.com>
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this issue
Nov 17, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Jacob Bandes-Storch <jacob@foxglove.dev>
james-rms
pushed a commit
to james-rms/rosbag2
that referenced
this issue
Nov 17, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: Jacob Bandes-Storch <jacob@foxglove.dev> Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Connects to #11
Implement a convert plugin to convert CDR to ROS 2 and vice versa.
The text was updated successfully, but these errors were encountered: