ros2GH-16 Fix naming of SerializationFormatConverterFactory

bosch-io · Oct 25, 2018 · a8a3ed5 · a8a3ed5
1 parent 1283d9b
commit a8a3ed5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/rosbag2/include/rosbag2/serialization_format_converter_factory.hpp b/rosbag2/include/rosbag2/serialization_format_converter_factory.hpp
@@ -42,13 +42,13 @@ class ClassLoader;
 namespace rosbag2
 {
 
-class ROSBAG2_PUBLIC SerializationFormatConverterFactoryImpl
+class ROSBAG2_PUBLIC SerializationFormatConverterFactory
   : public SerializationFormatConverterFactoryInterface
 {
 public:
-  SerializationFormatConverterFactoryImpl();
+  SerializationFormatConverterFactory();
 
-  ~SerializationFormatConverterFactoryImpl() override;
+  ~SerializationFormatConverterFactory() override;
 
   std::shared_ptr<SerializationFormatConverterInterface>
   load_converter(const std::string & format) override;

diff --git a/rosbag2/src/rosbag2/serialization_format_converter_factory.cpp b/rosbag2/src/rosbag2/serialization_format_converter_factory.cpp
@@ -23,7 +23,7 @@
 namespace rosbag2
 {
 
-SerializationFormatConverterFactoryImpl::SerializationFormatConverterFactoryImpl()
+SerializationFormatConverterFactory::SerializationFormatConverterFactory()
 {
   try {
     class_loader_ = std::make_unique<pluginlib::ClassLoader<SerializationFormatConverterInterface>>(
@@ -34,10 +34,10 @@ SerializationFormatConverterFactoryImpl::SerializationFormatConverterFactoryImpl
   }
 }
 
-SerializationFormatConverterFactoryImpl::~SerializationFormatConverterFactoryImpl() = default;
+SerializationFormatConverterFactory::~SerializationFormatConverterFactory() = default;
 
 std::shared_ptr<SerializationFormatConverterInterface>
-SerializationFormatConverterFactoryImpl::load_converter(const std::string & format)
+SerializationFormatConverterFactory::load_converter(const std::string & format)
 {
   auto converter_id = format + "_converter";
 

diff --git a/rosbag2/test/rosbag2/test_converter_factory.cpp b/rosbag2/test/rosbag2/test_converter_factory.cpp
@@ -24,7 +24,7 @@ using rosbag2::SerializationFormatConverterInterface;
 class ConverterFactoryTest : public ::testing::Test
 {
 public:
-  rosbag2::SerializationFormatConverterFactoryImpl factory;
+  rosbag2::SerializationFormatConverterFactory factory;
 };
 
 TEST_F(ConverterFactoryTest, load_test_plugin) {