Do not allow decommissioned node rejoining the cluster #8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Maslanka <michal@redpanda.com>
When new simple configuration is replicated after leaving joint consensus we still may send a request to follower that is going to be removed after the transition from joint to simple state. This way there is a chance that the follower will receive an information about it being removed from the cluster. The change introduced here is just an optimization and it does not influence correctness or configuration change semantics. It just allows the removed follower to discover its removal. The last configuration change delivery isn't guaranteed and it may happen that the follower will not receive it so we should not treat it as reliable mechanism to discover removal. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
Added a piece of logic that doesn't allow decommissioned node to rejoin the cluster after it is restarted. This way a node that was decommissioned will always require a data wipe to be able to join the cluster again. It will make restarting decommissioned safe. Fixes: redpanda-data#8404 Signed-off-by: Michal Maslanka <michal@redpanda.com>
…arts When Redpanda is started it may be the case that it will not be able to join the cluster but its process can still be up and running. To test this behavior we may need to start Redpanda without waiting for it to be fully operational. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
changed the title
ztlpn
approved these changes
Feb 1, 2023
bharathv
approved these changes
Feb 1, 2023
This was referenced Feb 2, 2023
|
/backport v22.3.x |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a piece of logic that doesn't allow decommissioned node to rejoin the cluster after it is restarted. This way a node that was decommissioned will always require a data wipe to be able to join the cluster again. It will make restarting decommissioned safe.
Fixes: #8404
Fixes: #8362
Backports Required
UX Changes
Release Notes
Improvements