Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow decommissioned node rejoining the cluster #8547

Merged
merged 6 commits into from
Feb 1, 2023
Merged

Do not allow decommissioned node rejoining the cluster #8547

merged 6 commits into from
Feb 1, 2023

Commits on Feb 1, 2023

  1. tests: use node removal waiter in node operations executor 

    Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9db0e31 View commit details
    Browse the repository at this point in the history

  2. r/replicate_entries_stm: do not skip sending request to removed follower 

    When new simple configuration is replicated after leaving joint
consensus we still may send a request to follower that is going to be
removed after the transition from joint to simple state. This way there
is a chance that the follower will receive an information about it being
removed from the cluster. The change introduced here is just an
optimization and it does not influence correctness or configuration
change semantics. It just allows the removed follower to discover its
removal.

The last configuration change  delivery isn't guaranteed and it may
happen that the follower will not receive it so we should not treat it
as reliable mechanism to discover removal.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    76a9c4e View commit details
    Browse the repository at this point in the history

  3. c/members_manager: log an error when a node is not able to join cluster 

    Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    313e471 View commit details
    Browse the repository at this point in the history

  4. c/members_manager: prevent decommissioned nodes from joining the cluster 

    Added a piece of logic that doesn't allow decommissioned node to rejoin
the cluster after it is restarted. This way a node that was
decommissioned will always require a data wipe to be able to join the
cluster again. It will make restarting decommissioned safe.

Fixes: redpanda-data#8404

Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fbe17b4 View commit details
    Browse the repository at this point in the history

  5. tests/redpanda: added option to skip readiness check when redpanda st… 

    …arts

When Redpanda is started it may be the case that it will not be able to
join the cluster but its process can still be up and running. To test
this behavior we may need to start Redpanda without waiting for it to be
fully operational.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a5a1b83 View commit details
    Browse the repository at this point in the history

  6. tests: added test validating that decommissioned node is unable to join 

    Signed-off-by: Michal Maslanka <michal@redpanda.com>
    @mmaslankaprv
    mmaslankaprv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    6e56861 View commit details
    Browse the repository at this point in the history