Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: check if decommission finished before recommissioning #7949

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

mmaslankaprv
Copy link
Member

Added check if the decommissioning finished before requesting recommission. If the node was already delete it is fine and we can pass the test.

Fixes: #7874

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

Release Notes

  • none

@mmaslankaprv
Copy link
Member Author

Ci failure: #7956

ztlpn
ztlpn previously approved these changes Dec 23, 2022
@graphcareful
Copy link
Contributor

/ci-repeat 2
skip-units
dt-repeat=100
tests/rptest/tests/nodes_decommissioning_test.py::NodesDecommissioningTest.test_flipping_decommission_recommission

Added check if the decommissioning finished before requesting
recommission. If the node was already delete it is fine and we can pass
the test.

Fixes: redpanda-data#7874

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
Copy link
Member Author

mmaslankaprv commented Jan 2, 2023

/ci-repeat 2
skip-units
dt-repeat=100
tests/rptest/tests/nodes_decommissioning_test.py::NodesDecommissioningTest.test_flipping_decommission_recommission

@mmaslankaprv
Copy link
Member Author

/ci-repeat 1

Signed-off-by: Michal Maslanka <michal@redpanda.com>
In `set_cluster_config` there is a check to make sure that configuration
was propagated across all the nodes. Using the `set_cluster_config` api
to make sure that all the nodes see up to date config before starting
decommissioning.

Signed-off-by: Michal Maslanka <michal@redpanda.com>
@mmaslankaprv
Copy link
Member Author

ci failure: #7991

@bharathv
Copy link
Contributor

bharathv commented Jan 5, 2023

Needs a backport to 22.3.x?

@mmaslankaprv
Copy link
Member Author

/backport v22.3.x

@vbotbuildovich
Copy link
Collaborator

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x 3142baca1a5fb8c50a5ce018f47149be1f463135 1b86d5894ea9f3a4510a8eb2137c3c12a3fb80d1 d7474eb2d421c12bc04ed45941c0db07d4c65930 8f3266f2bf7b4dc215ef93d25e2da2140d00c23e

Workflow run logs.

@ZeDRoman
Copy link
Contributor

@mmaslankaprv Have you backported it manually?

dotnwat added a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: test_flipping_decommission_recommission timing out
6 participants