Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Postgres client guide #1816

Merged
merged 6 commits into from
May 20, 2019

Conversation

tsegismont
Copy link
Contributor

Uses the Reactive Postgres client sample quarkusio/quarkus-quickstarts#130

@tsegismont
Copy link
Contributor Author

@FroMage I have updated this guide and the corresponding quickstart. Can you please take another look?

Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, requesting changes but they're all cosmetic.

docs/src/main/asciidoc/reactive-postgres-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-postgres-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-postgres-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-postgres-client.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-postgres-client.adoc Outdated Show resolved Hide resolved
@tsegismont
Copy link
Contributor Author

@cescoffier updated with media type constant

@tsegismont
Copy link
Contributor Author

@FroMage @cescoffier @emmanuelbernard can we merge this one too please? Thanks

@stuartwdouglas stuartwdouglas merged commit 4b82130 into quarkusio:master May 20, 2019
@stuartwdouglas stuartwdouglas added this to the 0.16.0 milestone May 20, 2019
@tsegismont
Copy link
Contributor Author

Thanks @stuartwdouglas !

@emmanuelbernard
Copy link
Member

We shuld make sure it gets added to the website in the data category, I forget if that's manual step or not @cescoffier @gsmet

@tsegismont tsegismont deleted the reactive-pg-client branch June 3, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants