-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive Postgres Client quickstart #130
Reactive Postgres Client quickstart #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a demo for the reactive-pg-client (using rxjava not axle) at https://github.com/jbossas/protean-rest-http-crud-demo/tree/master/quarkus-vertx/src/main/java/io/quarkus
I think we should change our demo to make it use axle, but I think it's cleaner if we keep the DB operations inside the Fruit
class like I did. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit puzzled by the different experience it's providing in comparison to Panache. I believe some integration work is required.
GH says not found when I click on this link.
I don't think about the |
I've asked for permission to be granted to you to look at it. Then we can debate which one looks better. My guess is that we may end up with a mix of the two. |
It's not perfect. As you said, an extension for the Reactive Pg Client would be an improvement. However the configuration bean uses Quarkus tech (Arc, Microprofile) so it's not terrible either. |
I had a look and it's indeed the same app with 2 differences:
As explained in the "Using Vert.x" guide, the Axle shim works nicely with the rest of Quarkus and MP API. So I believe it is better to use it in the guide. As for data access code in the entity, if it's a blocker I'll move do the changes here, but I believe this style would better a fit a Reactive Panache guide. |
We should totally use Axle and I should update the http-rest-client demo to that too, agreed. As for the SQL code location, I really think it should go in the entity to keep the model and controller logic separated. |
a10d8c5
to
a56ff73
Compare
LGTM, just two minor questions. |
a56ff73
to
9196447
Compare
@FroMage I've updated the PR. |
OK thanks. @cescoffier do you still have comments blocking this merge or shall we merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made a very very small comment. The rest looks good.
and it's merged! |
🍾🎉
And now the guide PR?
|
A sample RESTful application using the Reactive Pg Client to manage fruit entities.