Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalize icache / read-only cache dependency #105

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Externalize icache / read-only cache dependency #105

merged 7 commits into from
Aug 19, 2024

Conversation

micprog
Copy link
Member

@micprog micprog commented Mar 21, 2024 •
edited by SamuelRiedel
Loading

Changelog

Changed

  • Add dependency for icache, replacing cache located in snitch folder. This keeps files consistent across projects, allowing for updates and fixes to propagate properly. This update also fixes minor issues in cache wrt. duplicate entries in serial L1 lookup.

(Reference to issues, labels, and related merge requests)

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

@SamuelRiedel SamuelRiedel force-pushed the michaero/cluster_icache branch 2 times, most recently from d6465c7 to d168615 Compare August 16, 2024 14:11
sermazz
sermazz approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@sermazz sermazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SamuelRiedel SamuelRiedel merged commit e423768 into main Aug 19, 2024
58 checks passed
@SamuelRiedel SamuelRiedel deleted the michaero/cluster_icache branch August 19, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelRiedel SamuelRiedel SamuelRiedel approved these changes

@sermazz sermazz sermazz approved these changes

@mbertuletti mbertuletti Awaiting requested review from mbertuletti mbertuletti is a code owner

@yichao-zh yichao-zh Awaiting requested review from yichao-zh yichao-zh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micprog @SamuelRiedel @sermazz