Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document metamist's required Python version in setup.py #881

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jmarshall
Copy link
Contributor

I've long run metamist (and the rest of my CPG work) on Python 3.10, but at least since PR #861 this no longer works — as StrEnum was introduced in Python 3.11:

ImportError: cannot import name 'StrEnum' from 'enum' (/opt/homebrew/Cellar/python@3.10/3.10.14_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/enum.py)

This is mentioned in docs/installation.md, in which PR #696 bumped the documented requirement from 3.10 to 3.11.

This adds a mention in the canonical build-system place. (pyproject.toml would be even more canonical, but we don't use a [project] section there, so setup.py is the canonical place for this project.)

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (216bb11) to head (5f8b938).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #881   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         172      172           
  Lines       14641    14641           
=======================================
  Hits        11793    11793           
  Misses       2848     2848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant