Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenApi type generation for project roles #861

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

dancoates
Copy link
Contributor

Looks like pydantic/fastapi don't correctly handle usage of field serializers for int based enums being converted to strings, this switches to using a StrEnum instead.

@dancoates dancoates requested a review from milo-hyben July 8, 2024 23:34
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (c8402e4) to head (cb152c4).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #861   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files         172      172           
  Lines       14542    14538    -4     
=======================================
- Hits        11705    11702    -3     
+ Misses       2837     2836    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@milo-hyben milo-hyben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@dancoates dancoates merged commit 984609e into dev Jul 9, 2024
7 checks passed
@dancoates dancoates deleted the fix-project-roles-return branch July 9, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants