Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in nav bar that weren't links #879

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix links in nav bar that weren't links #879

merged 1 commit into from
Jul 24, 2024

Conversation

dancoates
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (60bb781) to head (aa1076c).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #879   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         172      172           
  Lines       14641    14641           
=======================================
  Hits        11793    11793           
  Misses       2848     2848

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dancoates dancoates merged commit 216bb11 into dev Jul 24, 2024
7 checks passed
@dancoates dancoates deleted the fix-metamist-nav-bar branch July 24, 2024 06:26
violetbrina
violetbrina approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@violetbrina violetbrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick sanity check of the change. Looks good and like it works!

@dancoates
Copy link
Contributor Author

Just did a quick sanity check of the change. Looks good and like it works!

Thanks! and sorry I merged before you reviewed, I was a bit trigger-happy there!

dancoates added a commit that referenced this pull request Jul 24, 2024
@dancoates @illusional
Release - nested sample filtering upgrades and navbar fix (#880)
4e8590c 
* Add more graphql filter options for nested samples (#878)

* Make nested sample column visible

* Allow requesting nested samples in GraphQL

---------

Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>

* fix links in nav bar that weren't links (#879)

---------

Co-authored-by: Michael Franklin <22381693+illusional@users.noreply.github.com>
Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violetbrina violetbrina violetbrina approved these changes

@illusional illusional illusional approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dancoates @violetbrina @illusional