Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more graphql filter options for nested samples #878

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

illusional
Copy link
Collaborator

And fix a bug where the parent / root sample fields on the project grid don't render if there aren't any sequencing groups.

@illusional illusional requested a review from nevoodoo July 19, 2024 06:23
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 40.62500% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (55cea0e) to head (101e36b).

Files Patch % Lines
api/graphql/schema.py 38.09% 13 Missing ⚠️
api/graphql/loaders.py 37.50% 5 Missing ⚠️
models/models/web.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #878      +/-   ##
==========================================
- Coverage   80.63%   80.54%   -0.09%     
==========================================
  Files         172      172              
  Lines       14611    14641      +30     
==========================================
+ Hits        11781    11793      +12     
- Misses       2830     2848      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illusional illusional merged commit 60bb781 into dev Jul 23, 2024
6 of 7 checks passed
@illusional illusional deleted the add-more-sample-filter-options branch July 23, 2024 21:22
dancoates added a commit that referenced this pull request Jul 24, 2024
* Add more graphql filter options for nested samples (#878)

* Make nested sample column visible

* Allow requesting nested samples in GraphQL

---------

Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>

* fix links in nav bar that weren't links (#879)

---------

Co-authored-by: Michael Franklin <22381693+illusional@users.noreply.github.com>
Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants