Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OurDNA Dashboard Enhancements #863

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Conversation

nevoodoo
Copy link
Collaborator

@nevoodoo nevoodoo commented Jul 9, 2024

No description provided.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 98.92473% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (0bae32f) to head (0e81c50).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
test/test_ourdna_dashboard.py 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #863      +/-   ##
==========================================
+ Coverage   80.02%   80.14%   +0.11%     
==========================================
  Files         172      172              
  Lines       14937    15022      +85     
==========================================
+ Hits        11953    12039      +86     
+ Misses       2984     2983       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nevoodoo nevoodoo force-pushed the SET-67-OurDNA-Dashboard-Enhancements branch from ee01980 to 41d6bcf Compare August 26, 2024 02:38
@nevoodoo nevoodoo marked this pull request as ready for review August 30, 2024 06:32
Copy link
Contributor

@milo-hyben milo-hyben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing regarding property name, otherwise looking good!

db/python/layers/ourdna/dashboard.py Show resolved Hide resolved
nevoodoo and others added 2 commits September 2, 2024 14:53
* SET-75 Fixed y-axis bug

* SET-73 added base for chart

* working cleanup

* SET-72 Added 24hr collection to process end time buckets tile
Copy link
Contributor

@milo-hyben milo-hyben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@nevoodoo nevoodoo merged commit 2023ae2 into dev Sep 3, 2024
7 checks passed
@nevoodoo nevoodoo deleted the SET-67-OurDNA-Dashboard-Enhancements branch September 3, 2024 04:09
nevoodoo added a commit that referenced this pull request Sep 10, 2024
* Better ETL accessors  (#897)

* Better ETL accessors (soon to action, analysis group)

* Apply pre-commit after rebase

* Docstring

* Add analysis group to etl accessors

* No red lines usually means it's fine

---------

Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>

* Updated etl fixes from deployment (#910)

* Deploy fixes

* Bump version

* PR clean-up

* Let the load method handle both dict / list requests

---------

Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>

* Fixing etl-load function, removing wrong check. (#911)

* Fixing etl load (#912)

* Fixing etl-load function, removing wrong check.

* Fixing by-type key of etl-load.

* Sonaqube scanner (#915)

* OurDNA Dashboard Enhancements (#863)

* SET-68 Added initial 1-3 day buckets by processing times

* SET-74 SET-68 fixed queries and added collection site/processing chart

* minor null fix on ODD

* OurDNA Dashboard UI Enhancements (#908)

* SET-75 Fixed y-axis bug

* SET-73 added base for chart

* working cleanup

* SET-72 Added 24hr collection to process end time buckets tile

* Updated field for collection-lab

* Testing WF identity for Sonar (#917)

* testing WF identity

* testing WF identity

* Renamed workflow

* Remove Google Auth from Sonarqube Workflow (#918)

* testing WF identity

* testing WF identity

* Renamed workflow

* final workflow

* Fix frontend linting and formatting (#916)

* organize imports

* add prettier check to linting workflow

* fix linting errors

* add working dir to frontend commands

* fix borked import organization in some files

* fix formatting commands so they get all files

they weren't working cos the glob was being processed by zsh rather than
prettier.

* fix ourdna dashboard linting error

* fix precommit problems

* fix some type errors

* Bump Packages (#919)

* bumping packages to patch vulns

* placing pin on dev only

* more upgrades

* fixed stale requirements-dev.txt

* final upgrades

* fixed pip-compile command

* Update sonarqube project id (#923)

* Save test coverage and upload to sonarqube (#924)

* Save test coverage and upload to sonarqube

* Pass linting

* Add pip audit (#920)

* Added pip-audit workflow

* added runs-on

* running only on dev reqs file

* added checkout repo action

* added requirements.txt back

* Sonarqube show coverage (#925)

* Save test coverage and upload to sonarqube

* Pass linting

* Refactor to have sonarqube be in the test.yaml file

* Test

* Rename

* More renaming

* Fix needs keyword

* Add Sonarqube condition

---------

Co-authored-by: Michael Franklin <22381693+illusional@users.noreply.github.com>
Co-authored-by: Michael Franklin <illusional@users.noreply.github.com>
Co-authored-by: Milo Hyben <milo-hyben@users.noreply.github.com>
Co-authored-by: Sabrina Yan <9669990+violetbrina@users.noreply.github.com>
Co-authored-by: Dan Coates <dan.coates@populationgenomics.org.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants