Billing pre-release #605
Merged
Billing pre-release #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* START: add billing home page and data page * REFACTOR: NavBar * REFACTOR: NavBar * REFACTOR: NavBar - adding dropdown meny capability * ../ * FIX: fixed style in the nav. Everythign but search bar * FIX: search bar fixed * DONE: menu and billing pages done * REMOVE: remove redundant code * LINT: fix format
* User Story 1.3: As a user, I want to sort costs by budget and by the percentage of budget used * First version of Current Billing Cost page. * Added dropdown to select grouping by Project, Topic or Dataset.
…ries with daily granularity in the billing dashboard (#588) * Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart wiht more custom properties.
* FIX: navbar style fix * FIX: Dropdown to FieldSelector in BillingInvoiceMonthCost * API: add api changes to allow the get running cost query to filter using invoice month * API: add api changes to allow the get running cost query to filter using invoice month * FIX: Dropdown to FieldSelector in BillingInvoiceMonthCost * FIX: all pages and navigation/links working * FIX: fixed all of the navigate() issues now all links work * IN PROGRESS: trying to cache the call to the seqr prop map API endpoint. UI cleaned up. * LINT: fix typing issues in API * RM: console.log
… in the dev table. (#591)
* REFACOR: move data loading logic into the main page to be used by all charts * LINT: fix format * FIX: bug fix for _.uniq issue * LINT: fix format
* Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart with more custom properties. * First version of Bar and Donut charts. * Upgrading babel / vulnerability.
This reverts commit c8248df.
* Bill 112 (#583) * START: add billing home page and data page * REFACTOR: NavBar * REFACTOR: NavBar * REFACTOR: NavBar - adding dropdown meny capability * ../ * FIX: fixed style in the nav. Everythign but search bar * FIX: search bar fixed * DONE: menu and billing pages done * REMOVE: remove redundant code * LINT: fix format * [BIL-26] BILLING - User Story 1.3 (#578) * User Story 1.3: As a user, I want to sort costs by budget and by the percentage of budget used * First version of Current Billing Cost page. * Added dropdown to select grouping by Project, Topic or Dataset. * [BIL-39] User Story 2.3: As a user, I want to view costs in a time series with daily granularity in the billing dashboard (#588) * Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart wiht more custom properties. * Bill 150 (#589) * FIX: navbar style fix * FIX: Dropdown to FieldSelector in BillingInvoiceMonthCost * API: add api changes to allow the get running cost query to filter using invoice month * API: add api changes to allow the get running cost query to filter using invoice month * FIX: Dropdown to FieldSelector in BillingInvoiceMonthCost * FIX: all pages and navigation/links working * FIX: fixed all of the navigate() issues now all links work * IN PROGRESS: trying to cache the call to the seqr prop map API endpoint. UI cleaned up. * LINT: fix typing issues in API * RM: console.log * Extended bq looks back time to 300 days as we do not have much loaded in the dev table. (#591) * Billing cost by time data refactor (#592) * REFACOR: move data loading logic into the main page to be used by all charts * LINT: fix format * FIX: bug fix for _.uniq issue * LINT: fix format * Bil 225 (#596) * IN PROGRESS: data table on over time cost page * DONE: data table on time view page complete * LINT: fix format * FIX: rename of variables * UPDATE: frontend now checks if the the billing endpoint is returning an OK status or not. Hides billing pages on any failed (not 200) status --------- Co-authored-by: Milo Hyben <milo-hyben@users.noreply.github.com>
* Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart with more custom properties. * First version of Bar and Dount charts. * Upgrading babel / vulnerability.
* Fixing last 24H billing calculations. * Limit Budget % and 24H to only latest month. * Pick only the latest monthly budget row per gcp_project. * Added Last 24H UTC day to the table header. * Removing unused job_config.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #605 +/- ##
==========================================
- Coverage 70.56% 69.66% -0.91%
==========================================
Files 116 116
Lines 9316 9517 +201
==========================================
+ Hits 6574 6630 +56
- Misses 2742 2887 +145 ☔ View full report in Codecov by Sentry. |
illusional
reviewed
Nov 13, 2023
* FIX: revert analysi.py, fix unused import * FIX: endpoint naming consistency * FIX: additional get_invoice_month_range comment detail * FIX: revert analysis.py db layer * FIX: remove hard coding in billing.py db layer * FIX: add clarrifying comments to billing.py layer * FIX: switch to defaultdict in billing layer, also some error message clarrification * FIX: Decimal to float
illusional
approved these changes
Nov 17, 2023
milo-hyben
added a commit
that referenced
this pull request
Nov 20, 2023
* Bill 112 (#583) * START: add billing home page and data page * FIX: fixed style in the nav. Everythign but search bar * DONE: menu and billing pages done * REMOVE: remove redundant code * User Story 1.3: As a user, I want to sort costs by budget and by the percentage of budget used * First version of Current Billing Cost page. * Added dropdown to select grouping by Project, Topic or Dataset. * [BIL-39] User Story 2.3: As a user, I want to view costs in a time series with daily granularity in the billing dashboard (#588) * Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart wiht more custom properties. * Bill 150 (#589) * API: add api changes to allow the get running cost query to filter using invoice month * IN PROGRESS: trying to cache the call to the seqr prop map API endpoint. UI cleaned up. * RM: console.log * Extended bq looks back time to 300 days as we do not have much loaded in the dev table. (#591) * REFACOR: move data loading logic into the main page to be used by all charts * DONE: data table on time view page complete * Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart with more custom properties. * First version of Bar and Donut charts. * Upgrading babel / vulnerability. * Bil 242 - Hide billing pages when env variables aren't set (#600) * DONE: menu and billing pages done * REMOVE: remove redundant code * API: add api changes to allow the get running cost query to filter using invoice month * FIX: Dropdown to FieldSelector in BillingInvoiceMonthCost * FIX: all pages and navigation/links working * FIX: fixed all of the navigate() issues now all links work * IN PROGRESS: trying to cache the call to the seqr prop map API endpoint. UI cleaned up. * LINT: fix typing issues in API * RM: console.log * Extended bq looks back time to 300 days as we do not have much loaded in the dev table. (#591) * Billing cost by time data refactor (#592) * IN PROGRESS: data table on over time cost page * DONE: data table on time view page complete * UPDATE: frontend now checks if the the billing endpoint is returning an OK status or not. Hides billing pages on any failed (not 200) status --------- * Added gcp-projects API to billing, new Billing CostByTime page * Updated StackedAreaByDateChart with more custom properties. * First version of Bar and Dount charts. * Upgrading babel / vulnerability. * Billing - show 24H table fields only to the current invoice month (#604) * Fixing last 24H billing calculations. * Limit Budget % and 24H to only latest month. * Pick only the latest monthly budget row per gcp_project. * Added Last 24H UTC day to the table header. * Removing unused job_config. * Fixing docker image building issues. * Getting gcp_project data from gcp_billing view instead of aggregated view. (#606) * Small fix to enable query cost by ar-guid, added example to API docs. (#611) --------- Co-authored-by: Sabrina Yan <9669990+violetbrina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes before release.