Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing small fixes #601

Merged
merged 21 commits into from
Nov 3, 2023
Merged

Billing small fixes #601

merged 21 commits into from
Nov 3, 2023

Conversation

milo-hyben
Copy link
Contributor

@milo-hyben milo-hyben commented Nov 2, 2023

This is based on Billing branch and added few minor fixes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1705d7b) 72.35% compared to head (22829ea) 70.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##           billing     #601      +/-   ##
===========================================
- Coverage    72.35%   70.62%   -1.74%     
===========================================
  Files          113      116       +3     
  Lines         9081     9424     +343     
===========================================
+ Hits          6571     6656      +85     
- Misses        2510     2768     +258     
Files Coverage Δ
api/routes/__init__.py 100.00% <100.00%> (+7.14%) ⬆️
db/python/layers/billing.py 15.06% <ø> (ø)
api/utils/dates.py 23.52% <0.00%> (-5.05%) ⬇️
models/models/billing.py 83.73% <40.00%> (-1.86%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milo-hyben milo-hyben marked this pull request as ready for review November 2, 2023 05:18
@milo-hyben milo-hyben merged commit ee8b231 into billing Nov 3, 2023
2 checks passed
@milo-hyben milo-hyben deleted the billing-small-fixes branch November 3, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants