Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project and sample id filter #511

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Add project and sample id filter #511

merged 2 commits into from
Jul 17, 2023

Conversation

danielreti
Copy link
Contributor

Closes #510

I tagged everyone for an FYI and also so I can get 3 sanity checks

violetbrina
violetbrina approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@violetbrina violetbrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Have you been able to test that it works locally?

@danielreti
Copy link
Contributor Author

Yup it works locally

daniaki
daniaki approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@daniaki daniaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM, and the filter seems to be working for you locally

@danielreti danielreti merged commit 92f6dde into dev Jul 17, 2023
5 checks passed
@danielreti danielreti deleted the add-project-and-sample-id-filter branch July 17, 2023 02:31
vivbak added a commit that referenced this pull request Jul 18, 2023
@vivbak @danielreti
@illusional @EddieLF @daniaki
Release (#513)
ddd9d31 
* Fix Mismatched Samples count (#498)

* fixed API turning all smaples as true and fixed project grid showing all samples not just active ones

* linting

* moved active check

* moved active type conversion to sample model

* Post sg UI fixes (#501)

* small fixes to project and analysis grids

* Added link to css overflow blogpost

* Update backup script to fetch new credentials (#502)

* Fix get analysis by id query (#503)

* Fix get analysis by ID (+ simplify analysis tests)

* Linting

* Cohort builder schema (#497)

* Cohort builder schema

* Fix bad copy-paste

* Fix nullable specification

* Add internal pid to ParticipantUpsert constructor from ParsedParticipant object (#505)

* Add blob.reload() call to cloudhelper get_gcs_blob (#506)

* Audit module and test update for SG changes (#509)

* Audit module and test update for SG changes

* Remove datasets list from audithelper

* Typehint fixes for linting

* Add project and sample id filter (#511)

* Allows uses to filter on sample ID within a project

* remove prints

* Bump version: 6.0.6 -> 6.1.0 (#512)

* Update deploy.yaml (#517)

* Update deploy.yaml

* Ignore pyenv and dotenv files

* update names to kebab-case

* add new line to make end-of-file-fixer happy

* ignore mypy cache

---------

Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com>

---------

Co-authored-by: danielreti <47542969+danielreti@users.noreply.github.com>
Co-authored-by: Michael Franklin <michael.franklin@populationgenomics.org.au>
Co-authored-by: EddieLF <34049565+EddieLF@users.noreply.github.com>
Co-authored-by: daniaki <7043686+daniaki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniaki daniaki daniaki approved these changes

@violetbrina violetbrina violetbrina approved these changes

@vivbak vivbak vivbak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't filter on internal ID within a project
4 participants
@danielreti @daniaki @violetbrina @vivbak